[core] memoize context values for react/jsx-no-constructed-context-values #34849
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Janpot
requested review from
michaldudak,
mnajdova,
siriwatknp and
danilo-leal
as code owners
6 tasks
michaldudak
approved these changes
Oct 28, 2022
Comment on lines
98
to
101
| if (disabled && focused) { | ||
| // NOTE: Setting state during render? | ||
| setFocused(false); | ||
| } |
There was a problem hiding this comment.
Yeah, this should be in a useEffect. Good catch.
Suggested change
| if (disabled && focused) { | |
| // NOTE: Setting state during render? | |
| setFocused(false); | |
| } | |
| React.useEffect(() => { | |
| if (disabled && focused) { | |
| setFocused(false); | |
| } | |
| }, [disabled, focused]); |
There was a problem hiding this comment.
Opened a separate PR #34916
This was referenced Oct 28, 2022
daniel-rabe
pushed a commit
to daniel-rabe/material-ui
that referenced
this pull request
Nov 29, 2022
feliperli
pushed a commit
to jesrodri/material-ui
that referenced
this pull request
Dec 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Memoize context values to satisfy eslint for #34642
Together with #34846 this concludes most fixes for: #34642