[docs] Fix scroll issue on expanded live demos #35064
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
|
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
|
@bharatkashyap Ah awesome, I could reproduce, thanks for raising. I have:
|
|
I'm merging as something is wrong with the GitHub CI action, Bharat won't be able to merge, I had to use the MUI Core admin right to override the missing CI run. |
|
FYI this still happening on the live documentation website. Tried the changes on local and seems to be working ok though 👍 |
2 tasks
|
@codeinearts we will likely deploy this change tomorrow to https://mui.com. The fix is only on https://master--material-ui.netlify.app/ right now. |
daniel-rabe
pushed a commit
to daniel-rabe/material-ui
that referenced
this pull request
Nov 29, 2022
Co-authored-by: Olivier Tassinari <[email protected]>
feliperli
pushed a commit
to jesrodri/material-ui
that referenced
this pull request
Dec 6, 2022
Co-authored-by: Olivier Tassinari <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #35095
This is a follow-up on #34870, fixing this bug:
Scroll.mov
The solution is to move the style override to the same
styled()element so that emotion can inject the styles in the right order in the DOM.https://deploy-preview-35064--material-ui.netlify.app/material-ui/react-tabs/#basic-tabs