[Base] Allow useSlotProps to receive undefined elementType #35192
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
michaldudak
reviewed
Nov 18, 2022
| otherProps: OtherProps, | ||
| ownerState: OwnerState, | ||
| ): AppendOwnerStateReturnType<ElementType, OtherProps, OwnerState> { | ||
| if (isHostComponent(elementType)) { | ||
| if (elementType && isHostComponent(elementType)) { |
There was a problem hiding this comment.
There's no need to append ownerState when ElementType is not defined.
Suggested change
| if (elementType && isHostComponent(elementType)) { | |
| if (elementType === undefined || isHostComponent(elementType)) { |
There was a problem hiding this comment.
Thanks for the quick review! My bad, fixed it.
michaldudak
reviewed
Nov 21, 2022
| @@ -29,7 +29,7 @@ export type AppendOwnerStateReturnType< | |||
| /** | |||
| * Appends the ownerState object to the props, merging with the existing one if necessary. | |||
| * | |||
| * @param elementType Type of the element that owns the `existingProps`. If the element is a DOM node, `ownerState` is not applied. | |||
| * @param elementType Type of the element that owns the `existingProps`. If the element is undefined or a DOM node, `ownerState` is not applied. | |||
There was a problem hiding this comment.
nit: the DOM node case is likely much more common, so I'd put it first.
Suggested change
| * @param elementType Type of the element that owns the `existingProps`. If the element is undefined or a DOM node, `ownerState` is not applied. | |
| * @param elementType Type of the element that owns the `existingProps`. If the element is a DOM node or undefined, `ownerState` is not applied. |
michaldudak
approved these changes
Nov 21, 2022
mnajdova
approved these changes
Nov 23, 2022
daniel-rabe
pushed a commit
to daniel-rabe/material-ui
that referenced
this pull request
Nov 29, 2022
feliperli
pushed a commit
to jesrodri/material-ui
that referenced
this pull request
Dec 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To make this PR #34793 possible, we agreed to extend useSlotProps with the support for undefined component types.
See this comment: #34793 (comment)