[Select] Revert "Update renderValue prop's TypeScript type (#34177)"

[michaldudak]

This reverts commit fea32da (PR #34177).

Fixes #35728 but reopens #34083.

The #34177 PR can be reapplied in v6 as it causes a breaking change in type definitions.

[mui-bot]

	Messages
📖	Netlify deploy preview: https://deploy-preview-35733--material-ui.netlify.app/

No bundle size changes

Generated by 🚫 dangerJS against 0f1a159

[jonesmac]

Thanks @michaldudak. I took a stab at trying to fix the issue as well and here's where I ended up.

I fully understand the value adding stronger types may have added, but I don't know if it belongs in the core library. Anytime you try to make interface properties change their type based off sibling interface properties (i.e. displayEmpty affecting renderValue) that feels best served as a runtime check OR splitting the interface to break the dependency.

For instance:

interface DisplayNotEmpty<T> {
      displayEmpty?: false;
      multiple?: boolean;
      renderValue?: (value: T) => React.ReactNode;
}

interface DisplayEmpty<T> {
      displayEmpty?: true;
      multiple?: false;
      renderValue?: (value: T | '') => React.ReactNode;
}

interface DisplayEmptyMultiple<T> {
      displayEmpty?: true;
      multiple?: true;
      renderValue?: (value: T) => React.ReactNode;
}

export interface SelectProps<T> extends CommonProps<T> {
  renderType: DisplayNotEmpty<T> | DisplayEmpty<T> | DisplayEmptyMultiple<T>
}

Allows for:

interface SelectExProps extends SelectProps<number> {
  
}

Example here - https://codesandbox.io/s/awesome-dewdney-r0vrpk?file=/src/App.tsx

[ZeeshanTamboli]

@michaldudak Thanks for the quick PR. I didn't anticipate this would cause an issue in #34177 .

[mnajdova]

Thanks. Yeah, I had a feeling #34177 may break some users of the library. Lesson learned for us :)