Use root element to handle focus, clicks and keyboard interactions #35744
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@material-ui/unstyled: parsed: +0.34% , gzip: +0.45% |
trizotti
changed the title
mnajdova
added
component: switch
|
@michaldudak , could you take a look? |
michaldudak
reviewed
Jan 23, 2023
Comment on lines
+136
to
+154
| const handleOnClick = (event: React.BaseSyntheticEvent) => { | ||
| setCheckedState(!checked); | ||
| setFocusVisible(false); | ||
| const nativeEvent = event.nativeEvent || event; | ||
| // @ts-ignore | ||
| const clonedEvent = new nativeEvent.constructor(nativeEvent.type, nativeEvent); | ||
| Object.defineProperty(clonedEvent, 'target', inputRef.current); | ||
| onChange?.(clonedEvent); | ||
| }; | ||
|
|
||
| const handleOnKeyPress = (e: React.KeyboardEvent) => { | ||
| if (e.code === 'Space' && inputRef.current) { | ||
| setCheckedState(!checked); | ||
| } | ||
| }; | ||
|
|
||
| const handleOnFocus = () => { | ||
| setFocusVisible(true); | ||
| }; |
There was a problem hiding this comment.
Ideally, these event handlers should be specified in useSwitch, so they won't have to be reimplemented in userland each time someone uses out hook. Plus, this will allow not to export the setCheckedState, as the API should be declarative if only possible (value / defaultValue instead of setValue).
github-actions
bot
added
the
PR: out-of-date
|
Since there are no updates after Michał's review, I am closing this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mui/base-ui#15