Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Avatar][joy] Remove imgProps prop and add Codemod script for migration #35859

Merged
merged 12 commits into from
Jan 23, 2023

Conversation

hbjORbj
Copy link
Member

@hbjORbj hbjORbj commented Jan 18, 2023

This PR includes:

  • Remove imgProps prop from Joy Avatar component
  • Codemod script that transforms the prop into using slotProps.img only for Joy Avatar component, not Material
  • Add the codemod to README
  • Add migration guide to Avatar docs

Sorry, something went wrong.

@hbjORbj hbjORbj added breaking change component: avatar This is the name of the generic UI component, not the React module! package: joy-ui Specific to @mui/joy labels Jan 18, 2023
@hbjORbj hbjORbj self-assigned this Jan 18, 2023
@mui-bot
Copy link

mui-bot commented Jan 18, 2023

Messages
📖 Netlify deploy preview: https://deploy-preview-35859--material-ui.netlify.app/

Details of bundle changes

Generated by 🚫 dangerJS against 23585fe

@hbjORbj hbjORbj changed the title [Avatar][joy] Remove imgProps prop and add Codemod script for migration Draft: [Avatar][joy] Remove imgProps prop and add Codemod script for migration Jan 18, 2023
@hbjORbj hbjORbj changed the title Draft: [Avatar][joy] Remove imgProps prop and add Codemod script for migration [Avatar][joy] Remove imgProps prop and add Codemod script for migration Jan 18, 2023
@hbjORbj hbjORbj requested a review from siriwatknp January 18, 2023 08:53
@hbjORbj hbjORbj added the package: codemod Specific to @mui/codemod label Jan 18, 2023
@hbjORbj hbjORbj added this to the Joy UI stable release milestone Jan 19, 2023
@hbjORbj hbjORbj force-pushed the joy/remove-imgProps branch from 71112ff to 8337e9f Compare January 19, 2023 06:36
Copy link
Member

@siriwatknp siriwatknp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Great job!

@hbjORbj hbjORbj merged commit 07d6161 into mui:master Jan 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking change component: avatar This is the name of the generic UI component, not the React module! package: codemod Specific to @mui/codemod package: joy-ui Specific to @mui/joy
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants