-
-
Notifications
You must be signed in to change notification settings - Fork 32.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Avatar][joy] Remove imgProps
prop and add Codemod script for migration
#35859
Merged
+168
−16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
imgProps
prop and add Codemod script for migrationimgProps
prop and add Codemod script for migration
imgProps
prop and add Codemod script for migrationimgProps
prop and add Codemod script for migration
siriwatknp
reviewed
Jan 19, 2023
siriwatknp
reviewed
Jan 19, 2023
packages/mui-codemod/src/v5.0.0/joy-avatar-remove-imgProps.test/expected.js
Show resolved
Hide resolved
71112ff
to
8337e9f
Compare
siriwatknp
approved these changes
Jan 20, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Great job!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
breaking change
component: avatar
This is the name of the generic UI component, not the React module!
package: codemod
Specific to @mui/codemod
package: joy-ui
Specific to @mui/joy
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes:
imgProps
prop from JoyAvatar
componentslotProps.img
only for JoyAvatar
component, not Material