Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[website] Add Albert to the about page #35954

Merged
merged 1 commit into from
Feb 4, 2023
Merged

Conversation

mj12albert
Copy link
Member

@mj12albert mj12albert commented Jan 26, 2023

@mui-bot
Copy link

mui-bot commented Jan 26, 2023

Messages
📖 Netlify deploy preview: https://deploy-preview-35954--material-ui.netlify.app/

No bundle size changes

Generated by 🚫 dangerJS against 8c9cdba

@mj12albert mj12albert added the website Pages that are not documentation-related, marketing-focused. label Jan 26, 2023
@mj12albert mj12albert marked this pull request as ready for review January 26, 2023 10:20
@mj12albert mj12albert requested a review from a team January 26, 2023 10:20
@oliviertassinari
Copy link
Member

oliviertassinari commented Jan 26, 2023

I think that it would be good to isolate public API changes, from website changes (2 PRs).

For instance, it's not obvious to me that Mastodon should be in the icon package because too niche (2M active users?, 1% of Twitter), maybe it's better as an internal website component.

@mj12albert
Copy link
Member Author

I think that it would be good to isolate public API changes, from website changes (2 PRs).

For instance, it's not obvious to me that Mastodon should be in the icon package because too niche (2M active users?), maybe it's better as an internal website component.

Alright, let me split it up ~

@oliviertassinari
Copy link
Member

oliviertassinari commented Jan 26, 2023

Awesome, in the GitHub issues, we proposed https://simpleicons.org/ a few times to the community.

@mj12albert
Copy link
Member Author

Finally done – didn’t realize until the last minute there’s a secret challenge to cut out the img background too 😅

@mj12albert mj12albert requested a review from siriwatknp February 3, 2023 13:09
Copy link
Member

@siriwatknp siriwatknp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Great to have you on the team!

@mj12albert mj12albert merged commit b76f606 into mui:master Feb 4, 2023
@mj12albert mj12albert deleted the me branch February 4, 2023 01:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
website Pages that are not documentation-related, marketing-focused.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants