Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump JSDOM to 21.x #35972

Merged
merged 1 commit into from
Jan 30, 2023
Merged

Bump JSDOM to 21.x #35972

merged 1 commit into from
Jan 30, 2023

Conversation

eps1lon
Copy link
Member

@eps1lon eps1lon commented Jan 28, 2023 •
edited by oliviertassinari
Loading

Adds caching to getComputedStyles for perf. Want to check if this didn't break anything

If I remember correctly test_unit had quite the range but 336.15s (branch) vs 538.74s (master) looks promising.

jsdom changelog: https://github.com/jsdom/jsdom/blob/master/Changelog.md#2110.

@mui-bot
Copy link

mui-bot commented Jan 28, 2023 •
edited
Loading

Messages
📖 Netlify deploy preview: https://deploy-preview-35972--material-ui.netlify.app/

No bundle size changes

Generated by 🚫 dangerJS against dbaa34c

@eps1lon eps1lon added the test label Jan 28, 2023
@eps1lon eps1lon marked this pull request as ready for review January 28, 2023 09:32
@eps1lon eps1lon mentioned this pull request Jan 28, 2023
Closed
1 task
@oliviertassinari oliviertassinari added dependencies Update of dependencies scope: code-infra Specific to the core-infra product labels Jan 28, 2023
michaldudak
michaldudak approved these changes Jan 29, 2023
View reviewed changes
Copy link
Member

@michaldudak michaldudak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The perf improvements are impressive. Thanks for the PR!

@hbjORbj hbjORbj merged commit 212585b into mui:master Jan 30, 2023
@eps1lon eps1lon deleted the test/jsdom-21 branch January 30, 2023 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaldudak michaldudak michaldudak approved these changes

Assignees
No one assigned
Labels
dependencies Update of dependencies scope: code-infra Specific to the core-infra product test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@eps1lon @mui-bot @michaldudak @oliviertassinari @hbjORbj