Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Joy] Add sign-in side template #36019

Merged
merged 11 commits into from
Feb 3, 2023
Merged

[Joy] Add sign-in side template #36019

merged 11 commits into from
Feb 3, 2023

Conversation

siriwatknp
Copy link
Member

@siriwatknp siriwatknp commented Feb 1, 2023 •
edited
Loading

Changes

  • split the preview of the template into 2 columns

    before:
    image

    After:
    image

  • Add sign-in template

    Screen Shot 2566-02-02 at 14 43 10 Screen Shot 2566-02-02 at 14 43 33

@siriwatknp siriwatknp added docs Improvements or additions to the documentation design: joy This is about Joy Design, please involve a visual or UX designer in the process labels Feb 1, 2023
@mui-bot
Copy link

mui-bot commented Feb 1, 2023 •
edited
Loading

Messages
📖 Netlify deploy preview: https://deploy-preview-36019--material-ui.netlify.app/

No bundle size changes

Generated by 🚫 dangerJS against cde7b43

@siriwatknp siriwatknp self-assigned this Feb 1, 2023
mnajdova
mnajdova reviewed Feb 1, 2023
View reviewed changes
Copy link
Member

@mnajdova mnajdova left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we fix the splash? Maybe using a darker background so that it's not that different before the picture loads? Or set a dark background on the whole body (or outer div).

login-screen-flash

docs/data/joy/getting-started/templates/sign-in-side/App.tsx Outdated Show resolved Hide resolved
docs/data/joy/getting-started/templates/sign-in-side/App.tsx Outdated Show resolved Hide resolved
docs/data/joy/getting-started/templates/sign-in-side/App.tsx Outdated Show resolved Hide resolved
mnajdova
mnajdova approved these changes Feb 2, 2023
View reviewed changes
Copy link
Member

@mnajdova mnajdova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks much better! I don't have anything else to add.

@siriwatknp siriwatknp merged commit 2fa0c99 into mui:master Feb 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mnajdova mnajdova mnajdova approved these changes

@danilo-leal danilo-leal Awaiting requested review from danilo-leal

Assignees

@siriwatknp siriwatknp

Labels
design: joy This is about Joy Design, please involve a visual or UX designer in the process docs Improvements or additions to the documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@siriwatknp @mui-bot @mnajdova