-
-
Notifications
You must be signed in to change notification settings - Fork 32.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Grid2] Support dynamic nested columns #36401
Conversation
Netlify deploy previewBundle size report |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The logic and demos look good. I left one comment on the CSS variable name.
@siriwatknp should we merge this one? |
would be possible to check if this issue: is cause by this pr? I think this doesn't work if the parent is not a grid, I Was able to fix the issue above adding the columns prop, not sure if we should default the column prop to the theme column number |
@francescovenica most likely. I just noticed the same issue. |
closes #36335
Before:
The nested grid container does not get the
--Grid-columns
value from its parent because it is overridden by its own variable. The fix is similar to how nested spacing works.https://stackblitz.com/edit/react-6xxqec?file=demo.tsx
After
https://codesandbox.io/s/material-cra-ts-forked-55ep57?file=/src/App.tsx