Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs][base] Move styles to the bottom of demos code for SliderUnstyled #36721

Merged
merged 3 commits into from
Apr 28, 2023
Merged

[docs][base] Move styles to the bottom of demos code for SliderUnstyled #36721

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ffa2be5
unstyled slider styles sent to bottom
varunmulay22 Mar 31, 2023
c820c78
Move default exports to the top
michaldudak Apr 28, 2023
f116797
Merge remote-tracking branch 'upstream/master' into unstyled-slider-s…
michaldudak Apr 28, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
57 changes: 28 additions & 29 deletions docs/data/base/components/slider/DiscreteSlider.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,34 @@ import PropTypes from 'prop-types';
import { styled, alpha, Box } from '@mui/system';
import SliderUnstyled, { sliderUnstyledClasses } from '@mui/base/SliderUnstyled';

function SliderValueLabel({ children }) {
return <span className="valueLabel">{children}</span>;
}

SliderValueLabel.propTypes = {
children: PropTypes.element.isRequired,
};

function valuetext(value) {
return `${value}°C`;
}

export default function DiscreteSlider() {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's move this first after the import statements.

return (
<Box sx={{ width: 300 }}>
<StyledSlider
aria-label="Temperature"
defaultValue={30}
getAriaValueText={valuetext}
step={10}
marks
min={10}
max={110}
slots={{ valueLabel: SliderValueLabel }}
/>
</Box>
);
}
const blue = {
100: '#DAECFF',
200: '#99CCF3',
Expand Down Expand Up @@ -122,32 +150,3 @@ const StyledSlider = styled(SliderUnstyled)(
}
`,
);

function SliderValueLabel({ children }) {
return <span className="valueLabel">{children}</span>;
}

SliderValueLabel.propTypes = {
children: PropTypes.element.isRequired,
};

function valuetext(value) {
return `${value}°C`;
}

export default function DiscreteSlider() {
return (
<Box sx={{ width: 300 }}>
<StyledSlider
aria-label="Temperature"
defaultValue={30}
getAriaValueText={valuetext}
step={10}
marks
min={10}
max={110}
slots={{ valueLabel: SliderValueLabel }}
/>
</Box>
);
}
57 changes: 28 additions & 29 deletions docs/data/base/components/slider/DiscreteSlider.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,34 @@ import * as React from 'react';
import { styled, alpha, Box } from '@mui/system';
import SliderUnstyled, { sliderUnstyledClasses } from '@mui/base/SliderUnstyled';

interface SliderValueLabelProps {
children: React.ReactElement;
}

function SliderValueLabel({ children }: SliderValueLabelProps) {
return <span className="valueLabel">{children}</span>;
}

function valuetext(value: number) {
return `${value}°C`;
}

export default function DiscreteSlider() {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here x the others.

return (
<Box sx={{ width: 300 }}>
<StyledSlider
aria-label="Temperature"
defaultValue={30}
getAriaValueText={valuetext}
step={10}
marks
min={10}
max={110}
slots={{ valueLabel: SliderValueLabel }}
/>
</Box>
);
}
const blue = {
100: '#DAECFF',
200: '#99CCF3',
Expand Down Expand Up @@ -121,32 +149,3 @@ const StyledSlider = styled(SliderUnstyled)(
}
`,
);

interface SliderValueLabelProps {
children: React.ReactElement;
}

function SliderValueLabel({ children }: SliderValueLabelProps) {
return <span className="valueLabel">{children}</span>;
}

function valuetext(value: number) {
return `${value}°C`;
}

export default function DiscreteSlider() {
return (
<Box sx={{ width: 300 }}>
<StyledSlider
aria-label="Temperature"
defaultValue={30}
getAriaValueText={valuetext}
step={10}
marks
min={10}
max={110}
slots={{ valueLabel: SliderValueLabel }}
/>
</Box>
);
}
71 changes: 35 additions & 36 deletions docs/data/base/components/slider/DiscreteSliderMarks.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,41 @@ import * as React from 'react';
import { styled, alpha, Box } from '@mui/system';
import SliderUnstyled, { sliderUnstyledClasses } from '@mui/base/SliderUnstyled';

const marks = [
{
value: 0,
label: '0°C',
},
{
value: 20,
label: '20°C',
},
{
value: 37,
label: '37°C',
},
{
value: 100,
label: '100°C',
},
];

function valuetext(value) {
return `${value}°C`;
}

export default function DiscreteSliderMarks() {
return (
<Box sx={{ width: 300 }}>
<StyledSlider
aria-label="Temperature"
defaultValue={37}
getAriaValueText={valuetext}
marks={marks}
/>
</Box>
);
}
const blue = {
100: '#DAECFF',
200: '#99CCF3',
Expand Down Expand Up @@ -119,39 +154,3 @@ const StyledSlider = styled(SliderUnstyled)(
}
`,
);

const marks = [
{
value: 0,
label: '0°C',
},
{
value: 20,
label: '20°C',
},
{
value: 37,
label: '37°C',
},
{
value: 100,
label: '100°C',
},
];

function valuetext(value) {
return `${value}°C`;
}

export default function DiscreteSliderMarks() {
return (
<Box sx={{ width: 300 }}>
<StyledSlider
aria-label="Temperature"
defaultValue={37}
getAriaValueText={valuetext}
marks={marks}
/>
</Box>
);
}
71 changes: 35 additions & 36 deletions docs/data/base/components/slider/DiscreteSliderMarks.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,41 @@ import * as React from 'react';
import { styled, alpha, Box } from '@mui/system';
import SliderUnstyled, { sliderUnstyledClasses } from '@mui/base/SliderUnstyled';

const marks = [
{
value: 0,
label: '0°C',
},
{
value: 20,
label: '20°C',
},
{
value: 37,
label: '37°C',
},
{
value: 100,
label: '100°C',
},
];

function valuetext(value: number) {
return `${value}°C`;
}

export default function DiscreteSliderMarks() {
return (
<Box sx={{ width: 300 }}>
<StyledSlider
aria-label="Temperature"
defaultValue={37}
getAriaValueText={valuetext}
marks={marks}
/>
</Box>
);
}
const blue = {
100: '#DAECFF',
200: '#99CCF3',
Expand Down Expand Up @@ -119,39 +154,3 @@ const StyledSlider = styled(SliderUnstyled)(
}
`,
);

const marks = [
{
value: 0,
label: '0°C',
},
{
value: 20,
label: '20°C',
},
{
value: 37,
label: '37°C',
},
{
value: 100,
label: '100°C',
},
];

function valuetext(value: number) {
return `${value}°C`;
}

export default function DiscreteSliderMarks() {
return (
<Box sx={{ width: 300 }}>
<StyledSlider
aria-label="Temperature"
defaultValue={37}
getAriaValueText={valuetext}
marks={marks}
/>
</Box>
);
}
73 changes: 36 additions & 37 deletions docs/data/base/components/slider/DiscreteSliderValues.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,42 @@ import * as React from 'react';
import { styled, alpha, Box } from '@mui/system';
import SliderUnstyled, { sliderUnstyledClasses } from '@mui/base/SliderUnstyled';

const marks = [
{
value: 0,
label: '0°C',
},
{
value: 20,
label: '20°C',
},
{
value: 37,
label: '37°C',
},
{
value: 100,
label: '100°C',
},
];

function valuetext(value) {
return `${value}°C`;
}

export default function DiscreteSliderValues() {
return (
<Box sx={{ width: 300 }}>
<StyledSlider
aria-label="Temperature"
defaultValue={37}
getAriaValueText={valuetext}
step={null}
marks={marks}
/>
</Box>
);
}
const blue = {
100: '#DAECFF',
200: '#99CCF3',
Expand Down Expand Up @@ -119,40 +155,3 @@ const StyledSlider = styled(SliderUnstyled)(
}
`,
);

const marks = [
{
value: 0,
label: '0°C',
},
{
value: 20,
label: '20°C',
},
{
value: 37,
label: '37°C',
},
{
value: 100,
label: '100°C',
},
];

function valuetext(value) {
return `${value}°C`;
}

export default function DiscreteSliderValues() {
return (
<Box sx={{ width: 300 }}>
<StyledSlider
aria-label="Temperature"
defaultValue={37}
getAriaValueText={valuetext}
step={null}
marks={marks}
/>
</Box>
);
}
Loading