-
-
Notifications
You must be signed in to change notification settings - Fork 32.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[docs] Add and revise Base UI + Create React App examples #36825
Conversation
Netlify deploy previewhttps://deploy-preview-36825--material-ui.netlify.app/ Bundle size report |
I know my startup page isn't the most beautiful thing in the world, but I think it's an improvement nonetheless! 😅 I wanted it to be helpful but didn't want to invest too much time into making it pretty. |
I wonder if we should invest in CRA examples as it's no longer a recommended way of starting a React project (reactjs/react.dev#5487 (comment), https://react.dev/learn/start-a-new-react-project) |
@michaldudak my goal in #36193 is to reach parity with Material UI for Base and Joy examples. I think CRA is still relevant and worth keeping around, even if it is falling out of fashion. I'll move on to Vite examples from here so we'll have those ready before the stable release. After that I think Next.js and Tailwind CSS will be the highest priorities. |
I know CRA isn't a big priority but we might as well merge this since it's here. 😅 Can I get a final review? |
...Or maybe we don't want any CRA examples anymore? See: #37367 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's go ahead and add these since you've already spent some time on them. I wouldn't create any new ones after that, though.
Part of #36193
Startup page before:
After: