[docs] Add a note about minimal required version for theme merging to the guides #36973
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jakub Šťastný <[email protected]>
Signed-off-by: Jakub Šťastný <[email protected]>
Netlify deploy preview
Bundle size report |
4 tasks
zannager
added
package: system
danilo-leal
changed the title
danilo-leal
reviewed
Apr 24, 2023
| @@ -122,6 +122,8 @@ Having more than one styling libraries could introduce unnecessary complexity to | |||
|
|
|||
| Material UI can coexist with other libraries that depend on emotion or styled-components. To do that, render Material UI's `ThemeProvider` as an inner provider and use the `THEME_ID` to store the theme. | |||
|
|
|||
| These changes have been added as recently as April 2023, so be sure you're running MUI v5.12.0 or higher. | |||
There was a problem hiding this comment.
Suggested change
| These changes have been added as recently as April 2023, so be sure you're running MUI v5.12.0 or higher. | |
| These changes have been added as recently as April 2023, so be sure you're running Material UI v5.12.0 or higher. |
Comment on lines
21
to
22
| ## Making sure you're on the right version of MUI | ||
| These changes have been added as recently as April 2023, so be sure you're running MUI v5.12.0 or higher. |
There was a problem hiding this comment.
Suggested change
| ## Making sure you're on the right version of MUI | |
| These changes have been added as recently as April 2023, so be sure you're running MUI v5.12.0 or higher. | |
| ## Making sure you're on the right version of Material UI | |
| These changes have been added as recently as April 2023, so be sure you're running Material UI v5.12.0 or higher. |
|
No worries @siriwatknp, glad to be of help. I suppose you don't need anything else from me? (I don't understand this GH PR workflow really, so...) |
Sorry for the confusion. In general, once the PR got approved you don't need to do anything, we will handle the rest. The approved PR usually got merged in the current week or at the beginning of the next week for the release. |
binh1298
pushed a commit
to binh1298/material-ui
that referenced
this pull request
May 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As has been discussed with @siriwatknp here #36664
Basically I have been confused myself by the guides, because the code used in them is VERY recent and since there was no warning, I lost time trying to figure out why is the guide not working for me.
This PR ads the minimal required MUI version to the 2 affected guides, as requested by @siriwatknp.