Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Timeline] Add alternate reverse position #37311

Merged
merged 17 commits into from
Jun 21, 2023
Merged

[Timeline] Add alternate reverse position #37311

merged 17 commits into from
Jun 21, 2023

Conversation

abhinavkmrru
Copy link
Contributor

@abhinavkmrru abhinavkmrru commented May 17, 2023 •
edited by ZeeshanTamboli
Loading

Closes #37275

@mui-bot
Copy link

mui-bot commented May 17, 2023 •
edited
Loading

Netlify deploy preview

Bundle size report

Details of bundle changes

Generated by 🚫 dangerJS against ec77f49

@zannager zannager requested a review from mnajdova May 18, 2023 07:34
@zannager zannager added the component: timeline This is the name of the generic UI component, not the React module! label May 18, 2023
@abhinavkmrru
Copy link
Contributor Author

@gzrae @mnajdova
All checks have been passed.
Kindly review it

@mnajdova mnajdova changed the title Abhinavkmrru issue#37275 [timeline] Add alternate reverse position May 29, 2023
mnajdova
mnajdova reviewed May 29, 2023
View reviewed changes
Copy link
Member

@mnajdova mnajdova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The implementation looks great. The only thing I could notice that can be improved is the API surface - the prop name.

packages/mui-lab/src/Timeline/Timeline.tsx Outdated Show resolved Hide resolved
packages/mui-lab/src/Timeline/Timeline.tsx Outdated Show resolved Hide resolved
packages/mui-lab/src/Timeline/Timeline.tsx Outdated Show resolved Hide resolved
docs/data/material/components/timeline/timeline.md Outdated Show resolved Hide resolved
docs/data/material/components/timeline/timeline.md Outdated Show resolved Hide resolved
abhinavkmrru and others added 9 commits June 1, 2023 12:19
@abhinavkmrru @mnajdova
Update packages/mui-lab/src/Timeline/Timeline.tsx
19de156 
Co-authored-by: Marija Najdova <[email protected]>
Signed-off-by: abhinavkmrru <[email protected]>
@abhinavkmrru @mnajdova
Update packages/mui-lab/src/Timeline/Timeline.tsx
f9c93dd 
Co-authored-by: Marija Najdova <[email protected]>
Signed-off-by: abhinavkmrru <[email protected]>
@abhinavkmrru @mnajdova
Update packages/mui-lab/src/Timeline/Timeline.tsx
9fd9303 
Co-authored-by: Marija Najdova <[email protected]>
Signed-off-by: abhinavkmrru <[email protected]>
@abhinavkmrru @mnajdova
Update docs/data/material/components/timeline/timeline.md
9e5d372 
Co-authored-by: Marija Najdova <[email protected]>
Signed-off-by: abhinavkmrru <[email protected]>
@abhinavkmrru @mnajdova
Update docs/data/material/components/timeline/timeline.md
8e5bdf0 
Co-authored-by: Marija Najdova <[email protected]>
Signed-off-by: abhinavkmrru <[email protected]>
@abhinavkmrru
timeline alternate-reverse modified to alternate-revert
e6f6866
@abhinavkmrru
Timeline following the convention; Wording change [{alternate-revert …
2df6bb3 
…-> alternate-reverse},{positionAlternateRevert -> positionAlternateReverse},{AlternateRevertTimeline -> AlternateReverseTimeline}]
@abhinavkmrru
Merge branch 'abhinavkmrru-issue#37275' of https://github.com/abhinav…
00dcfd9 
…kmrru/material-ui into abhinavkmrru-issue#37275
@abhinavkmrru
wording change revert to reverse
21f7818
@ZeeshanTamboli ZeeshanTamboli requested a review from mnajdova June 19, 2023 12:57
@ZeeshanTamboli ZeeshanTamboli changed the title [timeline] Add alternate reverse position [Timeline] Add alternate reverse position Jun 19, 2023
@ZeeshanTamboli ZeeshanTamboli added new feature New feature or request package: lab Specific to @mui/lab labels Jun 19, 2023
mnajdova
mnajdova approved these changes Jun 21, 2023
View reviewed changes
Copy link
Member

@mnajdova mnajdova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job! Thanks for the contribution 🙏

@mnajdova mnajdova merged commit a318f6a into mui:master Jun 21, 2023
@abhinavkmrru
Copy link
Contributor Author

abhinavkmrru commented Jun 22, 2023 via email

@ZeeshanTamboli ZeeshanTamboli mentioned this pull request Jun 22, 2023
Merged
1 task
@alexfauquette alexfauquette mentioned this pull request Aug 21, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mnajdova mnajdova mnajdova approved these changes

Assignees
No one assigned
Labels
component: timeline This is the name of the generic UI component, not the React module! new feature New feature or request package: lab Specific to @mui/lab
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Timeline alternate-reverse
5 participants
@abhinavkmrru @mui-bot @mnajdova @ZeeshanTamboli @zannager