-
-
Notifications
You must be signed in to change notification settings - Fork 32.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[docs] Update /base url references to /base-ui #37412
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, I fixed everything I could think of. Would be great if someone else can double check as I did lots of the changes :) cc @mui/core
@oliviertassinari should we use ahrefs to ensure that all the changes are correct? I remember that it was really helpful when I migrated material-ui to mui.com but I can't find the account to log in to ahrefs. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Tested, looks good. For safety, I recommend waiting for @oliviertassinari response about using ahrefs
to scan all the links of the deploy preview
@siriwatknp I think that https://www.screamingfrog.co.uk/seo-spider/ is already a great starting point. I did a quick run with it, it's limited to 500 URLs in the free version, and it didn't find anything. So next: ahrefs. I have invited you to ahrefs. I have also created this shared account so I don't have to add each person: https://www.notion.so/mui-org/Accounts-945f0ccb9f7749ccb9e84b9eb9b13ec7?pvs=4#141c93115cde4f1481fbb771809b9fcd and the next time It can happen without me. The crawl is in progress: https://app.ahrefs.com/site-audit/5024581/3/overview. I can find two problems:
![]() |
24122ec
to
3f20991
Compare
464816d
to
2a0ac5c
Compare
1b48a78
to
657a199
Compare
@siriwatknp @oliviertassinari No issues found in ahrefs audit. |
@siriwatknp I think that it's a first good step 👍 Next, I think that we will need to fix the product name and ranking path to be "base-ui", not "base": ![]() https://crawler.algolia.com/admin/crawlers/739c29c8-99ea-4945-bd27-17a1df391902/configuration/edit The simplest way to fix this might be to move the information outside of the Algolia's crawler. IMHO, this should have been inside the the HTML page for Algolia to extra from since the beginning. It's part of the action item in #16502.
@brijeshb42 I can find 6 broken links (404) from https://app.ahrefs.com/site-audit/5024581/4/data-explorer?columns=pageRating%2Curl%2Ctraffic%2ChttpCode%2Cdepth%2Ccompliant%2CincomingAllLinks%2Corigin&filterId=91013c8aafad4fe1f7a0ad504eccad42&issueId=c64da643-d0f4-11e7-8ed1-001e67ed4656&sorting=-pageRating that are still left to be fixed. Ideally 200, but 301 at worst. I can't find anything else that could be a regression. In the future, it would be awesome to change the markdown file location to match exactly with the URL, this would allows us to have more logic that is filename location based, hence be simpler to reason with. |
657a199
to
84a5bae
Compare
Added a fix for broken links found in ahrefs audit. I'll start the crawler again after the preview is ready to make sure the fix does not break anything else. |
84a5bae
to
512228e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💯 Great job! I could not detect any potential bug, thanks for working on this. The only last thing is to fix the E2E website CI.
512228e
to
21b63c0
Compare
Found 1 final issue but it's also on |
@brijeshb42 Sweet, I'm excited about this change! I have open 2 PRs to fix small issues. I can't notice anything else. |
Written by @mnajdova, @brijeshb42 please add something if I have missed.
Closes #36887
This changed in this PR:
getUrlProduct
logic to not change the product name cc @siriwatknp to validate this change.All redirects have been tested on the pull request preview.
https://deploy-preview-37412--material-ui.netlify.app/base-ui/getting-started/overview/