Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs][base] Add a Snackbar introduction demo #37602

Merged
merged 4 commits into from
Jun 16, 2023
Merged

Conversation

danilo-leal
Copy link
Contributor

@danilo-leal danilo-leal commented Jun 15, 2023

While browsing through the documentation yesterday, I realized we were lacking an intro demo for the Snackbar, which feels a bit inconsistent with all the other components. Usually, for these intro demos, it's nice to have a more fleshed-out example rather than a simpler one, to which point I again realized that the "Transitions" demo was really polished.

So, what I did was add an intro demo with the example that was being used in the Transitions section and then I simplified that to use the format all other demos were using just so we don't have two repeating polished examples.

Also took the opportunity to refine a bit the trigger button here and will eventually, in another PR, make sure all components that rely on a trigger button to be shown (menu, popper, modal, etc.) have consistent styles for it 🤙

Screen Shot 2023-06-15 at 19 05 31

@danilo-leal danilo-leal added docs Improvements or additions to the documentation component: snackbar This is the name of the generic UI component, not the React module! package: base-ui Specific to @mui/base labels Jun 15, 2023
@danilo-leal danilo-leal requested a review from michaldudak June 15, 2023 22:11
Copy link
Member

@michaldudak michaldudak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@danilo-leal danilo-leal merged commit 65af1e2 into master Jun 16, 2023
@danilo-leal danilo-leal deleted the base-snackbar-intro branch June 16, 2023 11:49
@danilo-leal danilo-leal self-assigned this Jun 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: snackbar This is the name of the generic UI component, not the React module! docs Improvements or additions to the documentation package: base-ui Specific to @mui/base
Projects
Status: Recently completed
Development

Successfully merging this pull request may close these issues.

2 participants