-
-
Notifications
You must be signed in to change notification settings - Fork 32.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[docs][base] Add Tailwind CSS & plain CSS demos on the Popper page #37953
[docs][base] Add Tailwind CSS & plain CSS demos on the Popper page #37953
Conversation
Netlify deploy previewBundle size report |
docs/data/base/components/popper/UnstyledPopperBasic/css/index.tsx
Outdated
Show resolved
Hide resolved
@mnajdova is the Tailwind demo like this on dark mode for you too? I don't understand why the |
Is there any specific reason we don't reuse the styles of the buttons from the Button docs? I feel they look better, and they have better contrast when hovered over. |
The reasons were to 1. Keep consistent with the other buttons on the page (outlined) and 2. The demo is not the button itself, so having an outlined version would represent the secondary hierarchy. Though we had these reasons when it was done, I also feel that the demos we have on the Button docs are better. Therefore, I'm down for revamping these from all the docs--maybe in a separate PR? |
I fixed it, for elements that render directly inside the |
@mnajdova do you know what can possibly be causing the |
Part of #37222