Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs][base] Add Tailwind CSS & plain CSS demos on the Popper page #37953

Merged
merged 6 commits into from
Jul 25, 2023

Conversation

zanivan
Copy link
Contributor

@zanivan zanivan commented Jul 13, 2023

Part of #37222

@zanivan zanivan added docs Improvements or additions to the documentation component: Popper The React component. See <Popup> for the latest version. package: base-ui Specific to @mui/base labels Jul 13, 2023
@zanivan zanivan requested a review from mnajdova July 13, 2023 20:49
@mui-bot
Copy link

mui-bot commented Jul 13, 2023

Netlify deploy preview

Bundle size report

No bundle size changes (Toolpad)
No bundle size changes

Generated by 🚫 dangerJS against b2861ad

@zanivan
Copy link
Contributor Author

zanivan commented Jul 19, 2023

@mnajdova is the Tailwind demo like this on dark mode for you too? I don't understand why the black: styles are not being applied to it. Do you know what could be causing this?

Screenshot 2023-07-19 at 11 08 24

@zanivan zanivan marked this pull request as ready for review July 19, 2023 16:14
@michaldudak
Copy link
Member

michaldudak commented Jul 20, 2023

Is there any specific reason we don't reuse the styles of the buttons from the Button docs? I feel they look better, and they have better contrast when hovered over.
Plus, we'd have one less variant to maintain.

@zanivan
Copy link
Contributor Author

zanivan commented Jul 20, 2023

Is there any specific reason we don't reuse the styles of the buttons from the Button docs?

The reasons were to 1. Keep consistent with the other buttons on the page (outlined) and 2. The demo is not the button itself, so having an outlined version would represent the secondary hierarchy.

Though we had these reasons when it was done, I also feel that the demos we have on the Button docs are better. Therefore, I'm down for revamping these from all the docs--maybe in a separate PR?

@mnajdova
Copy link
Member

mnajdova commented Jul 24, 2023

@mnajdova is the Tailwind demo like this on dark mode for you too? I don't understand why the black: styles are not being applied to it. Do you know what could be causing this?

I fixed it, for elements that render directly inside the body we need to have the dark class applied on the outer most element - the popper in this case. I also updated the migration steps with this note.

@zanivan
Copy link
Contributor Author

zanivan commented Jul 24, 2023

@mnajdova do you know what can possibly be causing the ci/circleci: test_lint fail? I thought it could be the box-shadow without px, but it appears that it's not it.

@zanivan zanivan merged commit b26f4d6 into mui:master Jul 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: Popper The React component. See <Popup> for the latest version. docs Improvements or additions to the documentation package: base-ui Specific to @mui/base
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants