Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Dialog][joy] Add DialogActions, DialogTitle and DialogContent #38382

Merged
merged 20 commits into from
Sep 7, 2023
Merged

[Dialog][joy] Add DialogActions, DialogTitle and DialogContent #38382

merged 20 commits into from
Sep 7, 2023

Conversation

siriwatknp
Copy link
Member

@siriwatknp siriwatknp commented Aug 8, 2023 •
edited
Loading

To achieve component parity with Material UI.

Before:

<ModalDialog aria-labelledby="title" aria-describedby="desc">
  <Typography level="title-lg" id="title">...</Typography>
  <Typography textColor="text.tertiary" id="desc">…</Typography>
</ModalDialog>

After:

<ModalDialog>
  <DialogTitle>...</DialogTitle>
  <DialogContent>…</DialogContent>
</ModalDialog>

DialogTitle

  • sync aria-labelledby with the ModalDialog

DialogContent

  • sync aria-describedby with the ModalDialog
  • overflow auto by default so that the content can be scrolled.

DialogActions

  • reuses styles from CardActions with the default orientation of horizontal-reverse

@siriwatknp siriwatknp added component: dialog This is the name of the generic UI component, not the React module! package: joy-ui Specific to @mui/joy labels Aug 8, 2023
@mui-bot
Copy link

mui-bot commented Aug 8, 2023 •
edited
Loading

Netlify deploy preview

@mui/joy: parsed: +0.98% , gzip: +0.85%

Bundle size report

Details of bundle changes (Toolpad)
Details of bundle changes

Generated by 🚫 dangerJS against c20cc7e

@siriwatknp siriwatknp marked this pull request as ready for review August 9, 2023 18:01
@zannager zannager requested a review from mnajdova August 10, 2023 07:03
@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Aug 10, 2023
@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label Aug 22, 2023
@siriwatknp siriwatknp self-assigned this Aug 22, 2023
@siriwatknp siriwatknp added the enhancement This is not a bug, nor a new feature label Aug 22, 2023
@siriwatknp siriwatknp requested a review from zanivan August 22, 2023 12:00
@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Aug 31, 2023
zanivan
zanivan approved these changes Sep 6, 2023
View reviewed changes
Copy link
Contributor

@zanivan zanivan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've added some tiny design tweaks to the demos, but overall, it looks like a great improvement 🚀

@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label Sep 7, 2023
@siriwatknp siriwatknp merged commit 76a3521 into mui:master Sep 7, 2023
mnajdova pushed a commit to mnajdova/material-ui that referenced this pull request Sep 8, 2023
@siriwatknp @mnajdova
[Dialog][joy] Add DialogActions, DialogTitle and DialogContent (m…
2a03494 
…ui#38382)
mnajdova pushed a commit to mnajdova/material-ui that referenced this pull request Sep 8, 2023
@siriwatknp @mnajdova
[Dialog][joy] Add DialogActions, DialogTitle and DialogContent (m…
fd98fba 
…ui#38382)
xcode-it pushed a commit to xcode-it/material-ui that referenced this pull request Sep 11, 2023
@siriwatknp @xcode-it
[Dialog][joy] Add DialogActions, DialogTitle and DialogContent (m…
cba6987 
…ui#38382)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zanivan zanivan zanivan approved these changes

@mnajdova mnajdova Awaiting requested review from mnajdova

Assignees

@siriwatknp siriwatknp

Labels
component: dialog This is the name of the generic UI component, not the React module! enhancement This is not a bug, nor a new feature package: joy-ui Specific to @mui/joy
Projects
Joy UI
Status: Recently completed
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@siriwatknp @mui-bot @zanivan