Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Autocomplete] Re-export AutocompleteValue to make it available from path import #38638

Merged
merged 2 commits into from
Sep 25, 2023
Merged

[Autocomplete] Re-export AutocompleteValue to make it available from path import #38638

merged 2 commits into from
Sep 25, 2023

Conversation

vadimka123
Copy link
Contributor

No description provided.

@vadimka123 vadimka123 changed the title Reexport AutocompleteValue through @mui/material [Autocomplete] Reexport AutocompleteValue through @mui/material Aug 25, 2023
@mui-bot
Copy link

mui-bot commented Aug 25, 2023

Netlify deploy preview

https://deploy-preview-38638--material-ui.netlify.app/

Bundle size report

No bundle size changes (Toolpad)
No bundle size changes

Generated by 🚫 dangerJS against 03e1285

@mnajdova
Copy link
Member

Can you please link the appropriate issue if it exists? Was the component exported before?

@mnajdova mnajdova added package: material-ui Specific to @mui/material component: autocomplete This is the name of the generic UI component, not the React module! labels Aug 25, 2023
@vadimka123
Copy link
Contributor Author

No any issue created
It's type and I think newer exported before

@zannager zannager requested a review from mnajdova August 25, 2023 11:10
@vadimka123
Copy link
Contributor Author

@mnajdova , can you please provide any update?
It’s simple change

Copy link
Member

@ZeeshanTamboli ZeeshanTamboli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vadimka123 But why do you need the type? How do you use it in your application?

@vadimka123
Copy link
Contributor Author

@ZeeshanTamboli , we using this type when building extended AutoComplete with header, footer and other features
AutocompleteValue having some hardcoded generics due to limitations of extended component

@ZeeshanTamboli ZeeshanTamboli changed the title [Autocomplete] Reexport AutocompleteValue through @mui/material [Autocomplete] Reexport AutocompleteValue to make it available from path import Sep 25, 2023
Copy link
Member

@ZeeshanTamboli ZeeshanTamboli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, I am considering this PR. It is available from top level import:

import { AutocompleteValue } from '@mui/material';

So it should be also available from path import:

import { AutocompleteValue } from '@mui/material/Autocomplete';

@ZeeshanTamboli ZeeshanTamboli changed the title [Autocomplete] Reexport AutocompleteValue to make it available from path import [Autocomplete] Re-export AutocompleteValue to make it available from path import Sep 25, 2023
@ZeeshanTamboli ZeeshanTamboli merged commit 27cc8c7 into mui:master Sep 25, 2023
mnajdova pushed a commit to mnajdova/material-ui that referenced this pull request Sep 25, 2023
…m path import (mui#38638)

Signed-off-by: Vadim Goy <[email protected]>
Co-authored-by: ZeeshanTamboli <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: autocomplete This is the name of the generic UI component, not the React module! package: material-ui Specific to @mui/material typescript
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants