-
-
Notifications
You must be signed in to change notification settings - Fork 32.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[joy-ui] Add Snackbar component #38801
Conversation
Netlify deploy preview@mui/joy: parsed: +1.93% , gzip: +1.75% Bundle size reportDetails of bundle changes (Toolpad) |
This reverts commit 0ca4344.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Thanks @ZeeshanTamboli
The component looks great. Few points for improving the demos:
|
I would leave the first point as is because applying color inversion by default could be too magical for some people and it is not efficient with zero-runtime in the future. We should let developers compose this feature by themselves. Agree with the rest! |
Then, IMO it's important to make this explicit in the docs—maybe on the inverted colors' demo. Otherwise, it'll look off, and might be mistaken for a bug. |
+1, if we don't plan to fix this (which I disagree with), we should remove this solid variant from the playground. It doesn't make sense to show a broken demo regardless of what are the technical limitations. |
I made the
Agreed. Decremented the duration counter by 100ms instead of 16ms. Ready for review! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Design-wise looks great! 🚀
Great contributon @ZeeshanTamboli! Thank you 🙏 |
It's great to see one more component in Joy UI. One thing I noticed from a design perspective that feels off is the distance to the edge of the screen. Feedback added to https://www.notion.so/mui-org/Olivier-design-review-on-Joy-Design-3ada9a7bcfa44b9fab1fe5032dfb33bb?pvs=4#559b0978badf4daba4af9aa712bb1fea. (Eventually, I think we should move all of this document to GitHub issues, there might be ~100 design GitHub issues to create, if we want to go very granular 😁) |
Agreed! I'll take a look on it!
I'll revisit the file and double check those items. We've already dealt with or thrown away many of those, but there's definitely a lot of feedback that we could turn into issues! For instance, this feedback about tabs fits perfectly with what we're trying to do on #39363 😁 |
Closes #36603
Preview - https://deploy-preview-38801--material-ui.netlify.app/joy-ui/react-snackbar/
TODO: