Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[material-ui][Button] Update the file upload demo #38823

Merged
merged 1 commit into from
Sep 6, 2023
Merged

[material-ui][Button] Update the file upload demo #38823

merged 1 commit into from
Sep 6, 2023

Conversation

danilo-leal
Copy link
Contributor

Following up on comments left at #38786.

  • Convert the styled component to the JavaScript notation.
  • Remove unnecessary href.

@danilo-leal danilo-leal added docs Improvements or additions to the documentation component: button This is the name of the generic UI component, not the React module! package: material-ui Specific to @mui/material labels Sep 5, 2023
@danilo-leal danilo-leal self-assigned this Sep 5, 2023
@mui-bot
Copy link

mui-bot commented Sep 5, 2023 •
edited
Loading

Netlify deploy preview

https://deploy-preview-38823--material-ui.netlify.app/

Bundle size report

No bundle size changes (Toolpad)
No bundle size changes

Generated by 🚫 dangerJS against 2ce9e55

mnajdova
mnajdova approved these changes Sep 6, 2023
View reviewed changes
Copy link
Member

@mnajdova mnajdova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👍

@danilo-leal danilo-leal merged commit 42005c6 into mui:master Sep 6, 2023
@danilo-leal danilo-leal deleted the button-file-material-demo branch September 6, 2023 10:35
mnajdova pushed a commit to mnajdova/material-ui that referenced this pull request Sep 8, 2023
@danilo-leal @mnajdova
[material-ui][Button] Update the file upload demo (mui#38823)
7adaf79
mnajdova pushed a commit to mnajdova/material-ui that referenced this pull request Sep 8, 2023
@danilo-leal @mnajdova
[material-ui][Button] Update the file upload demo (mui#38823)
508bcab
xcode-it pushed a commit to xcode-it/material-ui that referenced this pull request Sep 11, 2023
@danilo-leal @xcode-it
[material-ui][Button] Update the file upload demo (mui#38823)
8d7b8d6
@oliviertassinari oliviertassinari mentioned this pull request Feb 5, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mnajdova mnajdova mnajdova approved these changes

@DiegoAndai DiegoAndai Awaiting requested review from DiegoAndai

@siriwatknp siriwatknp Awaiting requested review from siriwatknp

Assignees

@danilo-leal danilo-leal

Labels
component: button This is the name of the generic UI component, not the React module! docs Improvements or additions to the documentation package: material-ui Specific to @mui/material
Projects
Joy UI
Status: Recently completed
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@danilo-leal @mui-bot @mnajdova