[core] Fix prop-types generation #38831
Conversation
Netlify deploy previewhttps://deploy-preview-38831--material-ui.netlify.app/ Bundle size report |
flaviendelangle
force-pushed
the
fix-proptypes
branch
2 times, most recently
from
172e348 to
a17b4b7
Compare
| } | ||
|
|
||
| // handle component factories: x = createComponent() | ||
| if ( | ||
| checkDeclarations && | ||
| node.initializer && | ||
| !isStyledFunction(node) && |
There was a problem hiding this comment.
Before getJSXLikeReturnValueFromFunction did not recognize React.ReactNode as a valid JSX response, so styled components were ignored.
Now they are supported, but we probably don't want them to be so I added a test to filter them out.
flaviendelangle
force-pushed
the
fix-proptypes
branch
from
a17b4b7 to
043d547
Compare
flaviendelangle
force-pushed
the
fix-proptypes
branch
from
043d547 to
0f2c71a
Compare
| @@ -0,0 +1,29 @@ | |||
| // eslint-disable-next-line no-restricted-imports -- importing types | |||
| import { InternalStandardProps as StandardProps } from '@mui/material'; | |||
There was a problem hiding this comment.
The name was wrong (tsx instead of ts) so the props were considered external (maybe we could loosen the implementedBySelfPropsFile variable in generateProptypes
| // Any components that are created by a factory function, e.g. System Box | Container | Grid. | ||
| getFromProp(node); | ||
| } else { |
There was a problem hiding this comment.
Allow to handle nested react.memo(react.forwardRef(...))
| @@ -250,14 +265,13 @@ function getPropsFromVariableDeclaration({ | |||
| }); | |||
| } | |||
| } | |||
|
|
|||
| return null; | |||
There was a problem hiding this comment.
Make sure that we test the createX pattern for all components, otherwise we might miss some
|
All right, it works great now for me. |
|
@michaldudak done 👌 |
flaviendelangle
force-pushed
the
fix-proptypes
branch
from
fb29229 to
af183e7
Compare
See #38517 (comment) for more context
All the problematic component should not correctly be generated, except the slider slots (but for me that's normal)