Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[base-ui][NumberInput] Support adornments #38900

Merged
merged 16 commits into from
Sep 20, 2023
Merged

[base-ui][NumberInput] Support adornments #38900

merged 16 commits into from
Sep 20, 2023

Conversation

anle9650
Copy link
Contributor

@anle9650 anle9650 commented Sep 10, 2023 •
edited by mj12albert
Loading

@mui-bot
Copy link

mui-bot commented Sep 10, 2023 •
edited
Loading

Netlify deploy preview

Bundle size report

Details of bundle changes (Toolpad)
Details of bundle changes

Generated by 🚫 dangerJS against 19ba83b

@anle9650 anle9650 marked this pull request as draft September 10, 2023 05:57
@anle9650 anle9650 marked this pull request as ready for review September 10, 2023 05:59
@zannager zannager added the package: base-ui Specific to @mui/base label Sep 11, 2023
@zannager zannager requested a review from mj12albert September 11, 2023 10:51
@danilo-leal danilo-leal changed the title [Base UI][number input] support adornments [base-ui][NumberInput] Support adornments Sep 11, 2023
@danilo-leal danilo-leal added new feature New feature or request component: number field This is the name of the generic UI component, not the React module! labels Sep 11, 2023
mj12albert
mj12albert reviewed Sep 14, 2023
View reviewed changes
Copy link
Member

@mj12albert mj12albert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@anle9650 Thanks for working on this ~ let's add a simple test to NumberInput.test.tsx

You can refer to this one and pass plain spans as adornments!

@anle9650
Copy link
Contributor Author

@mj12albert done!

mj12albert
mj12albert approved these changes Sep 19, 2023
View reviewed changes
Copy link
Member

@mj12albert mj12albert left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@anle9650 Looks good 👍

Let's just wait for @samuelsycamore to give the docs a quick look before merging ~

@mj12albert mj12albert merged commit 9124a83 into mui:master Sep 20, 2023
christophermorin pushed a commit to christophermorin/material-ui that referenced this pull request Sep 21, 2023
@anle9650 @mj12albert
@mapache-salvaje @christophermorin
[base-ui][NumberInput] Support adornments (mui#38900)
b5ce28a 
Signed-off-by: Andy Le <[email protected]>
Co-authored-by: Albert Yu <[email protected]>
Co-authored-by: Sam Sycamore <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mapache-salvaje mapache-salvaje mapache-salvaje left review comments

@mj12albert mj12albert mj12albert approved these changes

Assignees
No one assigned
Labels
component: number field This is the name of the generic UI component, not the React module! new feature New feature or request package: base-ui Specific to @mui/base
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[base-ui][NumberInput] Support adornments
6 participants
@anle9650 @mui-bot @mj12albert @mapache-salvaje @danilo-leal @zannager