Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs-infra] Improve callouts design #39084

Merged
merged 2 commits into from
Sep 26, 2023

Conversation

danilo-leal
Copy link
Contributor

@danilo-leal danilo-leal commented Sep 21, 2023

Closes #39066

This PR tackles the issue above and adds other stray color/element fixes mostly within the callout scope.

https://deploy-preview-39084--material-ui.netlify.app/material-ui/api/button-base/#ButtonBase-prop-component

Before After
Screen Shot 2023-09-20 at 21 53 09 Screen Shot 2023-09-20 at 21 52 48

@danilo-leal danilo-leal added design This is about UI or UX design, please involve a designer scope: docs-infra Specific to the docs-infra product labels Sep 21, 2023
@danilo-leal danilo-leal self-assigned this Sep 21, 2023
@mui-bot
Copy link

mui-bot commented Sep 21, 2023

Netlify deploy preview

https://deploy-preview-39084--material-ui.netlify.app/

Bundle size report

No bundle size changes (Toolpad)
No bundle size changes

Generated by 🚫 dangerJS against 2973a57

@danilo-leal danilo-leal requested a review from zanivan September 25, 2023 10:25
Copy link
Contributor

@zanivan zanivan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

design-wise, it looks good :)

@danilo-leal danilo-leal merged commit 239164e into mui:master Sep 26, 2023
@danilo-leal danilo-leal deleted the improve-docs-callouts branch September 26, 2023 01:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
design This is about UI or UX design, please involve a designer scope: docs-infra Specific to the docs-infra product
Projects
Status: Recently completed
Development

Successfully merging this pull request may close these issues.

[docs-infra] Misaligned icon in one-line callout
3 participants