Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core] Downgrade lerna to 7.2.0 #39149

Merged
merged 1 commit into from
Sep 25, 2023
Merged

Conversation

michaldudak
Copy link
Member

Lerna 7.3.0 throws an error when running yarn release:version. It's not very helpful:

lerna ERR! ERROR Not all tasks were run. This is likely a bug in Lerna.

In 7.2.0 everything works as expected.

@michaldudak michaldudak added the dependencies Update of dependencies label Sep 25, 2023
@mui-bot
Copy link

mui-bot commented Sep 25, 2023

Netlify deploy preview

https://deploy-preview-39149--material-ui.netlify.app/

Bundle size report

No bundle size changes (Toolpad)
No bundle size changes

Generated by 🚫 dangerJS against d439074

@michaldudak michaldudak requested review from a team and removed request for mnajdova September 25, 2023 11:09
Copy link
Member

@Janpot Janpot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just did quick test on Toolpad, we're on 7.3.0 and our version command works without error. Can't immediately find a recent issue reporting a problem with version, but it does seem like they worked on it in the last minor. There is no more context around this error?

@michaldudak
Copy link
Member Author

No, unfortunately. I'll dig into this, but I don't want to postpone the release now.

@michaldudak michaldudak merged commit fcf2f60 into mui:master Sep 25, 2023
@michaldudak michaldudak deleted the downgrade-lerna branch September 25, 2023 12:17
@LukasTy LukasTy mentioned this pull request Sep 26, 2023
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Update of dependencies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants