-
-
Notifications
You must be signed in to change notification settings - Fork 32.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[base-ui][Slider] Fix track=inverted
not working
#39265
Conversation
Netlify deploy preview
@material-ui/core: parsed: +Infinity% , gzip: +Infinity% Bundle size reportDetails of bundle changes (Toolpad) |
track=inverted
not working
Let me know if I should make a new PR where I have run the prettier command. |
Thanks for the PR! There's a couple of things to do:
|
Hi! The first two is an easy fix, but for the last one, do you only need proof that it works, or should I create a test in the slider.test.tsx file? Thanks in advance |
As we discussed on Discord, please create a test in Slider.test.tsx. |
#38848) Signed-off-by: Albert Yu <[email protected]> Co-authored-by: Michał Dudak <[email protected]>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
These redirections are helpful for the content of https://mui.com/store/items/figma-react/. and https://www.figma.com/community/file/912837788133317724. It avoids to duplicate the same link in multiple different locations.
Signed-off-by: Axel Boström <[email protected]> Co-authored-by: Zeeshan Tamboli <[email protected]>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: ZeeshanTamboli <[email protected]>
Closes mui/base-ui#48
Fixed the issue where the slider wouldn't come in from the right when using the: track={"inverted"}. Now working and all tests passed.