Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[base-ui][Slider] Fix track=inverted not working #39265

Closed
wants to merge 219 commits into from
Closed

[base-ui][Slider] Fix track=inverted not working #39265

wants to merge 219 commits into from

Conversation

olibo733
Copy link

@olibo733 olibo733 commented Oct 2, 2023

Closes mui/base-ui#48

Fixed the issue where the slider wouldn't come in from the right when using the: track={"inverted"}. Now working and all tests passed.

@mui-bot
Copy link

mui-bot commented Oct 2, 2023

Netlify deploy preview

@material-ui/core: parsed: +Infinity% , gzip: +Infinity%
@material-ui/lab: parsed: +Infinity% , gzip: +Infinity%
@material-ui/styles: parsed: +Infinity% , gzip: +Infinity%
@material-ui/private-theming: parsed: +Infinity% , gzip: +Infinity%
@material-ui/system: parsed: +Infinity% , gzip: +Infinity%
@material-ui/unstyled: parsed: +Infinity% , gzip: +Infinity%
@material-ui/utils: parsed: +Infinity% , gzip: +Infinity%
@mui/material-next: parsed: +Infinity% , gzip: +Infinity%
@mui/joy: parsed: +Infinity% , gzip: +Infinity%

Bundle size report

Details of bundle changes (Toolpad)
Details of bundle changes

Generated by 🚫 dangerJS against 682b9fb

@danilo-leal danilo-leal changed the title Fixed issue [Slider][base-ui] track=inverted does not work #38925 [base-ui][Slider] Fix track=inverted not working Oct 2, 2023
@danilo-leal danilo-leal added component: slider This is the name of the generic UI component, not the React module! package: base-ui Specific to @mui/base labels Oct 2, 2023
@olibo733
Copy link
Author

olibo733 commented Oct 2, 2023

Let me know if I should make a new PR where I have run the prettier command.

@michaldudak
Copy link
Member

Thanks for the PR!

There's a couple of things to do:

  • run yarn prettier and commit the result
  • rebase on top of the latest master
  • add a test verifying if the solution works as expected

@olibo733
Copy link
Author

olibo733 commented Oct 3, 2023

Thanks for the PR!

There's a couple of things to do:

* run `yarn prettier` and commit the result

* rebase on top of the latest master

* add a test verifying if the solution works as expected

Hi! The first two is an easy fix, but for the last one, do you only need proof that it works, or should I create a test in the slider.test.tsx file? Thanks in advance

@michaldudak
Copy link
Member

As we discussed on Discord, please create a test in Slider.test.tsx.

michaldudak and others added 20 commits October 10, 2023 11:24
renovate bot and others added 29 commits October 10, 2023 11:24
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
These redirections are helpful for the content of https://mui.com/store/items/figma-react/.
and https://www.figma.com/community/file/912837788133317724.
It avoids to duplicate the same link in multiple different locations.
Signed-off-by: Axel Boström <[email protected]>
Co-authored-by: Zeeshan Tamboli <[email protected]>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: ZeeshanTamboli <[email protected]>
@olibo733 olibo733 closed this Oct 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: slider This is the name of the generic UI component, not the React module! package: base-ui Specific to @mui/base
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Slider] track="inverted" does not work