-
-
Notifications
You must be signed in to change notification settings - Fork 32.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[core] Setup vale for enforcing style guides #39633
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for moving forward with this @alexfauquette !
.github/styles/Blog/Typos.yml
Outdated
eg: e.g. | ||
eg.: e.g. | ||
'e.g ': 'e.g. ' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this reminds me: can we add a rule to avoid Latinisms altogether? (etc., e.g., i.e.) - they're often confusing to non-native English speakers, and the latter two in particular are frequently misused. "etc." can always be cut or replaced with "and more", and "e.g" and "i.e." can be replaced with "for example."
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, Google has a Latin packge to detect eg
and ie
: https://github.com/errata-ai/Google/tree/master/Google
Other rules I'd love to see:
|
Signed-off-by: Alexandre Fauquette <[email protected]>
.github/styles/Blog/Typos.yml
Outdated
eg: e.g. | ||
eg.: e.g. | ||
'e.g ': 'e.g. ' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, Google has a Latin packge to detect eg
and ie
: https://github.com/errata-ai/Google/tree/master/Google
Signed-off-by: Alexandre Fauquette <[email protected]>
Can I let you add them in a follow-up PR? Most of the information about config is here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ship it! 🚀 Thank you @alexfauquette !! I'll continue to refine the rules after this gets merged, and I'll try to remember to open a PR on the X side as well if I come up with any that make sense to add there too! (Which reminds me: does the Toolpad repo have Vale? If not, we might as well add it there too 😁)
Signed-off-by: Alexandre Fauquette <[email protected]>
Fix #32486
@samuelsycamore That's a copy past from X (I only removed files about date pickers and data grid)