Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[docs-infra] Bring back scroll gradient in API page with table #39689

Merged
merged 6 commits into from
Nov 1, 2023
Merged

[docs-infra] Bring back scroll gradient in API page with table #39689

merged 6 commits into from
Nov 1, 2023

Conversation

alexfauquette
Copy link
Member

@alexfauquette alexfauquette commented Oct 31, 2023 •
edited
Loading

@alexfauquette alexfauquette added the scope: docs-infra Specific to the docs-infra product label Oct 31, 2023
@alexfauquette alexfauquette self-assigned this Oct 31, 2023
@mui-bot
Copy link

mui-bot commented Oct 31, 2023 •
edited
Loading

Netlify deploy preview

https://deploy-preview-39689--material-ui.netlify.app/

Bundle size report

No bundle size changes (Toolpad)
No bundle size changes

Generated by 🚫 dangerJS against b000d17

danilo-leal
danilo-leal approved these changes Nov 1, 2023
View reviewed changes
Copy link
Contributor

@danilo-leal danilo-leal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking great! Pushed a few tweaks here and there... appreciate you for picking this up! 🤙

@alexfauquette alexfauquette merged commit 112b833 into mui:master Nov 1, 2023
7 checks passed
@alexfauquette alexfauquette deleted the add-gradient branch November 1, 2023 21:30
oliviertassinari
oliviertassinari reviewed Nov 1, 2023
View reviewed changes
Copy link
Member

@oliviertassinari oliviertassinari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would breaking the prop names with a min-width of 200px be a better UX?

Screenshot 2023-11-02 at 00 22 30

@oliviertassinari oliviertassinari added the design This is about UI or UX design, please involve a designer label Nov 1, 2023
@oliviertassinari oliviertassinari mentioned this pull request Feb 15, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oliviertassinari oliviertassinari oliviertassinari left review comments

@danilo-leal danilo-leal danilo-leal approved these changes

Assignees

@alexfauquette alexfauquette

Labels
design This is about UI or UX design, please involve a designer scope: docs-infra Specific to the docs-infra product
Projects
Docs-infra
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@alexfauquette @mui-bot @oliviertassinari @danilo-leal