Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[material-ui][CardActions][DialogActions] Apply margin for all children except for 1st child #40168

Merged
merged 5 commits into from
Dec 13, 2023

Conversation

sai6855
Copy link
Contributor

@sai6855 sai6855 commented Dec 10, 2023

marginLeft style was incorrectly applied if children are of different types, this PR fixes the issue.

before

https://codesandbox.io/p/sandbox/focused-rain-9rj2m3?file=%2Fsrc%2FDemo.tsx%3A12%2C18

after

https://codesandbox.io/p/sandbox/hopeful-haze-hjt79j?file=%2Fsrc%2FDemo.tsx%3A1%2C1-20%2C1

@sai6855 sai6855 changed the title [material-ui][CardActions][DialogActions] Card accordion actions child [material-ui][CardActions][DialogActions] Apply margin for all children except for 1st child Dec 10, 2023
@sai6855 sai6855 marked this pull request as draft December 10, 2023 05:39
@sai6855 sai6855 added bug 🐛 Something doesn't work component: card This is the name of the generic UI component, not the React module! component: dialog This is the name of the generic UI component, not the React module! labels Dec 10, 2023
@mui-bot
Copy link

mui-bot commented Dec 10, 2023

Netlify deploy preview

https://deploy-preview-40168--material-ui.netlify.app/

Bundle size report

Details of bundle changes (Toolpad)
Details of bundle changes

Generated by 🚫 dangerJS against b99853a

@sai6855 sai6855 requested a review from DiegoAndai December 13, 2023 11:46
@sai6855 sai6855 marked this pull request as ready for review December 13, 2023 11:47
Copy link
Member

@DiegoAndai DiegoAndai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

We're probably moving to gap in v6 or v7: #31885

@DiegoAndai DiegoAndai merged commit 30484b8 into mui:master Dec 13, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something doesn't work component: card This is the name of the generic UI component, not the React module! component: dialog This is the name of the generic UI component, not the React module!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants