[joy-ui][FormControl] Fix issue with the conditional setting of htmlFor and id attributes not functioning properly for form labels
#40180
Conversation
Netlify deploy previewhttps://deploy-preview-40180--material-ui.netlify.app/ Bundle size reportDetails of bundle changes (Toolpad) |
danilo-leal
added
package: joy-ui
|
Hey @ReaZzy, I have a few suggestions, your PR currently lacks a description. To help the reviewers understand the changes you've made, could you please add a brief description that outlines the purpose of the PR, any proposed changes, and if applicable, mention if you've added or modified tests. Additionally, as this PR addresses a specific issue, you can link it by adding Thanks for your contribution! A member of the team will review your PR soon. |
ZeeshanTamboli
changed the title
htmlFor and id attributes not working for form label
ZeeshanTamboli
changed the title
htmlFor and id attributes not working for form labelhtmlFor and id attributes not working for form label
There was a problem hiding this comment.
@ReaZzy I moved the tests out of the Input test block since the Input component isn't rendered. Everything seems fine to me now! It's a great first pull request at MUI!
ZeeshanTamboli
changed the title
htmlFor and id attributes not working for form labelhtmlFor and id attributes not functioning properly for form labels
ReaZzy
deleted the
40112-htmlfor-and-id-attribute-disappears-when-set-to-undefined
branch
As mentioned by PhillipWinder in the bug report, if either the
'id'or'htmlFor'is undefined, they are currently removed from the DOM instead of being set to their default values. This issue arises due toexternalForwardedPropsoverridingadditionalProps. To address this, we can fix the problem by conditionally addinghtmlFor/idtoexternalForwardedProps. Additionally, I have included tests to verify that the behaviour with undefined values is now correct.Fixes #40112.