Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[styled-engine-sc] Fix theme being of type any #40200

Merged
merged 6 commits into from
Dec 15, 2023

Conversation

mnajdova
Copy link
Member

@mnajdova mnajdova commented Dec 13, 2023

Repository for testing the changes: https://github.com/mnajdova/mui-styled-engine-sc-theme-type

Check the theme type in the three use-cases in App.tsx.

Fixes #39783. The types were taken and adopted from @mui/styled-engine.

@mnajdova mnajdova added typescript package: styled-engine-sc Specific to styled-components labels Dec 13, 2023
@mui-bot
Copy link

mui-bot commented Dec 13, 2023

Netlify deploy preview

https://deploy-preview-40200--material-ui.netlify.app/

Bundle size report

No bundle size changes (Toolpad)
No bundle size changes

Generated by 🚫 dangerJS against f82ea76

@mnajdova mnajdova changed the title [styled-engine-sc] Fix css prop issue [styled-engine-sc] Fix theme being of type any Dec 13, 2023
@mnajdova mnajdova marked this pull request as ready for review December 14, 2023 09:50
@mnajdova mnajdova added the bug 🐛 Something doesn't work label Dec 14, 2023
@mnajdova mnajdova merged commit c06b102 into mui:master Dec 15, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something doesn't work package: styled-engine-sc Specific to styled-components typescript
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adding @mui/styled-engine-sc to tsconfig paths breaks theme type
3 participants