[code-infra] Break package dependency cycles #40398
Conversation
packages/mui-styles/package.json
Outdated
| @@ -40,6 +40,7 @@ | |||
| "dependencies": { | |||
| "@babel/runtime": "^7.23.6", | |||
| "@emotion/hash": "^0.9.1", | |||
| "@mui/material": "^5.15.2", | |||
There was a problem hiding this comment.
This change isn't strictly related to this PR, but I noticed this package imports @mui/material in production code, but doesn't declare it as a production dependency.
There was a problem hiding this comment.
This surprises me a bit. Intuitively I'd expect it to be the other way around. @mui/material depending on @mui/system.
Netlify deploy previewhttps://deploy-preview-40398--material-ui.netlify.app/ Bundle size reportDetails of bundle changes (Toolpad) |
packages/mui-styles/package.json
Outdated
| @@ -40,6 +40,7 @@ | |||
| "dependencies": { | |||
| "@babel/runtime": "^7.23.6", | |||
| "@emotion/hash": "^0.9.1", | |||
| "@mui/material": "^5.15.2", | |||
There was a problem hiding this comment.
This surprises me a bit. Intuitively I'd expect it to be the other way around. @mui/material depending on @mui/system.
michaldudak
force-pushed
the
break-dependency-cycles
branch
from
27d7bef to
5b3f1be
Compare
That's |
oops, right, that's what I meant 🙂 |
This PR removes dependency cycles (as reported by Lerna and pnpm on another branch) between workspace packages.
I moved tests that verify integration between packages into test/integration.
This change allows us to unlock Lerna version (pinned in #40029) and solves an issue with Lerna on the pnpm branch (the
versioncommand was failing because of the cycles).