-
-
Notifications
You must be signed in to change notification settings - Fork 32.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[blog] Add link to Base UI API changes RFC #41089
Conversation
Netlify deploy previewhttps://deploy-preview-41089--material-ui.netlify.app/ Bundle size report |
@@ -56,10 +56,11 @@ Additionally, since the `slots` and the corresponding `slotProps` are not relate | |||
To address these issues, we're considering adopting a new API that would assign a discrete subcomponent to each DOM node—the pattern favored by many other headless component libraries (think: `<Slider.Track />`, `<Slider.Thumb />`, etc.). | |||
This pattern has the potential to radically improve the customization experience, both for styles and structure. | |||
|
|||
We're still fleshing out the details and plan to release an RFC on GitHub in the coming days. | |||
We'll update this blog post with the link when it's available. | |||
We're still fleshing out the details. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We're still fleshing out the details. | |
We're still fleshing out the details, but we know |
(then the line below continues). @samuelsycamore, how about this so it's more connected to the next sentence? It reads a bit more natural to me that way!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good call!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually, these sentences could be in different paragraphs. The fact that we're working on the API details is a separate piece of information that that we want a smooth migration path.
What do you think about:
We are still fleshing out the API and implementation details. If you have any questions or remarks about this change, chime in on the RFC on GitHub.
We know that a significant number of projects depend on the existing API, and we want to assure you that one of our top priorities is to provide a smooth migration experience.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds great to me! 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perfect!
Co-authored-by: Danilo Leal <[email protected]> Signed-off-by: Michał Dudak <[email protected]>
Updated the Base UI blog post with a link to the RFC.