Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[code-infra] Bump node image used by CI in docker #42079

Merged
merged 2 commits into from
May 2, 2024
Merged

[code-infra] Bump node image used by CI in docker #42079

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
53d5576
[code-infra] Bump node image used by CI in docker
LukasTy May 1, 2024
08f8846
Try setting smart sudo as per the vale setup guide
LukasTy May 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion .circleci/config.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ default-job: &default-job
AWS_REGION_ARTIFACTS: eu-central-1
working_directory: /tmp/material-ui
docker:
- image: cimg/node:18.19
- image: cimg/node:18.20

default-context: &default-context
context:
Expand Down Expand Up @@ -215,6 +215,9 @@ jobs:
#!/bin/bash
VALE_STR_CLI_VERSION=3.3.0

# set smart sudo
if [[ $EUID -eq 0 ]]; then export SUDO=""; else export SUDO="sudo"; fi
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

L25@https://circleci.com/developer/orbs/orb/circleci/vale#orb-source

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm wondering, any idea why we don't use the orb directly?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That would be a question for @oliviertassinari.
Did you try the orb when introducing this step? 🤔


mkdir /tmp/vale-extract
cd /tmp/vale-extract
GZIPPED_OUTPUT="vale.tar.gz"
Expand Down
Loading