[PopOver] Fix Animation vertical

[tintin1343]

• PR has tests / docs demo, and is linted.
• Commit and PR titles begin with [ComponentName], and are in imperative form: "[Component] Fix leaky abstraction".
• Description explains the issue / use-case resolved, and auto-closes the related issue(s) (http://tr.im/vFqem).

Fixes the popover animation origin issue.

Animation starts from the point of click.

Closes : #4219

Current Issue:

Fix:

Also, the popover position looks alright to me, it scrolls correctly and closes when it should. @mbrookes and I were discussing it.Updating the react-event-listner solves the issue.

[mbrookes]

@mbrookes and I were discussing it.

Not me I don't think.

Apart from anything else:

"For inline display, such as on a form, consider using compact controls such as segmented dropdown buttons".

https://www.google.com/design/spec/components/pickers.html

[mbrookes]

[nathanmarks]

@mbrookes

I wonder if us terming it inline is somewhat deceiving -- especially since it isn't any more inline than the dialog version. The Popover is still rendering through a portal in the html document and breaking out of the document flow.

I wouldn't call our popover version of the datepicker "inline" -- but maybe that's just me. Stick an overlay style on the popover layer and you've pretty much got a dialog 😄

[mbrookes]

I don't think whatever inline should be called is a particularly useful feature as it stands. If it were me, I'd deprecate it in favour of an actual inline picker, rather than trying to fix it.

[nathanmarks]

@mbrookes me neither... and as long as DatePicker isn't crazy rigid, there's no reason people can't implement it the way we instruct people to implement menu if they really want it in a popover -- right? (using Popover).

[tintin1343]

Not me I don't think.

@mbrookes : I was talking about the weird scrolling issue which we were discussing on Saturday.

So what are we going to do about the inline thing? Are we keeping it as is or are we going to go with something new? The reason I am asking is because then I will temporarily halt my work on the inline-timepicker as well.

[nathanmarks]

@mbrookes @tintin1343

What shall we do what shall we do? 😄

[nathanmarks]

@tintin1343 in this PR does vertical expanding still work the other way?

[mbrookes]

No, it changes it. Unfortunately the changed version is also broken. See: #4222 (comment)

[mbrookes]

@tintin1343 closing for now. Feel free to reopen if you have another chance to look at it and still feel it's worth pursuing given that inline DatePicker in it's current form is not optimal.