[docs] Use slot variants over theme.variants
#42614
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
siriwatknp
added
package: material-ui
siriwatknp
requested review from
mnajdova,
danilo-leal,
DiegoAndai and
aarongarciah
Netlify deploy previewBundle size report |
docs/data/material/customization/theme-components/theme-components.md
Outdated
Show resolved
Hide resolved
docs/data/material/customization/theme-components/theme-components.md
Outdated
Show resolved
Hide resolved
docs/data/material/customization/theme-components/theme-components.md
Outdated
Show resolved
Hide resolved
docs/data/material/customization/theme-components/theme-components.md
Outdated
Show resolved
Hide resolved
docs/data/material/customization/theme-components/theme-components.md
Outdated
Show resolved
Hide resolved
mnajdova
reviewed
Jun 11, 2024
danilo-leal
reviewed
Jun 14, 2024
docs/data/material/customization/theme-components/theme-components.md
Outdated
Show resolved
Hide resolved
docs/data/material/customization/theme-components/theme-components.md
Outdated
Show resolved
Hide resolved
| }); | ||
| ``` | ||
|
|
||
| **Example 2**: Overriding styles based on new values. If your project needs a new Button's variant, use the following snippet: |
There was a problem hiding this comment.
For example, this doesn't feel like an override to me—it's a completely new thing that we're adding to the component's surface area.
There was a problem hiding this comment.
It's hard to justify. Even though it's about adding new value, it's still overriding the default styles of the Button.
mnajdova
reviewed
Jul 17, 2024
docs/data/material/customization/theme-components/theme-components.md
Outdated
Show resolved
Hide resolved
docs/data/material/customization/theme-components/theme-components.md
Outdated
Show resolved
Hide resolved
docs/data/material/customization/theme-components/theme-components.md
Outdated
Show resolved
Hide resolved
docs/data/material/customization/theme-components/theme-components.md
Outdated
Show resolved
Hide resolved
docs/data/material/customization/theme-components/theme-components.md
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Left copy-related comments for your consideration.
(Just saw @mnajdova submitted a review so maybe some comments collide, sorry about that)
docs/data/material/customization/theme-components/theme-components.md
Outdated
Show resolved
Hide resolved
docs/data/material/customization/theme-components/theme-components.md
Outdated
Show resolved
Hide resolved
docs/data/material/customization/theme-components/theme-components.md
Outdated
Show resolved
Hide resolved
docs/data/material/customization/theme-components/theme-components.md
Outdated
Show resolved
Hide resolved
mbrookes
previously requested changes
Jul 17, 2024
docs/data/material/customization/theme-components/theme-components.md
Outdated
Show resolved
Hide resolved
docs/data/material/customization/theme-components/theme-components.md
Outdated
Show resolved
Hide resolved
Co-authored-by: Marija Najdova <[email protected]> Signed-off-by: Siriwat K <[email protected]>
aarongarciah
approved these changes
Jul 23, 2024
joserodolfofreitas
pushed a commit
to joserodolfofreitas/material-ui
that referenced
this pull request
Jul 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #30412
Based on #30412 (comment),
theme.variantsis no longer needed.Using slot variants reduces the API surface, allows developers to customize any slot, and is compatible with Pigment CSS too.