-
-
Notifications
You must be signed in to change notification settings - Fork 32.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[material-ui][Snackbar] Remove notistack
library
#42739
[material-ui][Snackbar] Remove notistack
library
#42739
Conversation
Netlify deploy previewBundle size report |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we show usage with other libraries like react-toastify or sonner for vertically stacked snackbars?
Yeah, I think so! It'd make sense to replace notistack with something rather than just remove it (no hard preferences as far as making this right now in this PR or in a follow-up one). Generally speaking, we should still address the use case of vertically stacked snackbars somehow, with a recommendation of how we suggest pulling it off, while the component itself doesn't support it out of the box. I’m fine with both of these options.
I agree to replace |
Base UI will eventually work on their Toast component, which is planned for Q3 in the latest roadmap I could find. What would you say is the urgency of this issue @ZeeshanTamboli? If it can wait until Q4, I think we can add it to the Base UI refactor milestone. |
I think you meant the Material UI refactor milestone, right? I'm fine with that. Ideally, before removing |
This one: https://github.com/mui/material-ui/milestone/51 I'll add the issue to it |
Closes #42615
Originally, we added Material UI's Snackbar usage with
notistack
to show vertically stacked Snackbars. I was working on implementing this feature directly in Material UI (see PR #31991), but the PR was halted for various reasons.Should we show usage with other libraries like react-toastify or sonner for vertically stacked snackbars?
Also, should this be cherry-picked to the
master
branch? I think it should.