-
-
Notifications
You must be signed in to change notification settings - Fork 32.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[website] Update showcase to include Toolpad Core #43226
[website] Update showcase to include Toolpad Core #43226
Conversation
Netlify deploy previewhttps://deploy-preview-43226--material-ui.netlify.app/ Bundle size report |
That isn't from a change in this PR, that one is already merged in #42952 We can fix that separately I think - an item to add in the grooming next week? |
I think we can make the code preview more to the point. It doesn't have to be the exact same as what we render. e.g. look at the the MUI X code preview. I think we can also leave out the explanation text that we add for Studio. The code can speak for itself. We can inline and reduce the amount of navigation and leave out the other props and children, what do you think of just the following as a preview? <AppProvider navigation={[
{
kind: 'header',
title: 'Main items',
},
{
segment: 'dashboard',
title: 'Dashboard',
icon: <DashboardIcon />,
}
// ...
]}>
<DashboardLayout>
<PageContainer>
{/* ... */}
</PageContainer>
</DashboardLayout>
</AppProvider> |
Agree with shortening the preview code. About the Studio description, I would keep at least one sentence talking about Studio being a drag and drop builder given there isn't any context around it anywhere else on the landing page. |
Yes, we can keep the studio one, I meant we can remove it for the core tab. Sorry, I wasn't very clear there 😄 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
@bharatkashyap Can you look into this scroll issue? Screen.Recording.2024-08-13.at.15.14.09.mov |
Screen.Recording.2024-08-15.at.1.39.49.PM.mov@prakhargupta1 @Janpot Updated with a fix for the reported scroll issue, is this good to merge now? |
Update the Products switcher copy for Toolpad
Update the demo tabs
Add the
<DashboardLayout />
as the demo for "Core"Merge the earlier demo tabs into one for "Studio"
as a single description