-
-
Notifications
You must be signed in to change notification settings - Fork 32.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[docs][toolpad] Remove extra code block #44120
base: master
Are you sure you want to change the base?
Conversation
Netlify deploy previewBundle size report |
The demo is quite hard to follow, I thought the point was that this code could be simpler and shown before the demo. |
or, as a preview? Like we show in most demos? |
@prakhargupta1 I don't understand this, right now in https://deploy-preview-44120--material-ui.netlify.app/material-ui/react-dialog/#toolpad-beta, we have noise: and when we open the demo, we have to struggle to find the piece that I want to copy and paste in my project. I think that the right move is to:
|
0d530ad
to
d29529e
Compare
d29529e
to
0e82de7
Compare
4e8f4a8
to
d3b412b
Compare
@bharatkashyap Do you mind changing the |
…terial-ui into fix/toolpad-docs-dialog
From #43796 (comment)
Preview: https://deploy-preview-44120--material-ui.netlify.app/material-ui/react-dialog/