[CardHeader] Deprecate *TypographyProps and complete slots, slotProps
#44729
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
siriwatknp
added
the
component: card
siriwatknp
changed the title
titleTypographyProps and subheaderTypographyProps*TypographyProps and complete slots, slotProps
Netlify deploy previewCardHeader: parsed: +3.28% , gzip: +2.80% Bundle size reportDetails of bundle changes (Toolpad) |
35 tasks
github-actions
bot
added
the
PR: out-of-date
…ecation/card-header
github-actions
bot
removed
the
PR: out-of-date
|
Seems like we're missing the migration guide section |
siriwatknp
commented
Jan 9, 2025
| @@ -80,13 +80,14 @@ const CardHeader = React.forwardRef(function CardHeader(inProps, ref) { | |||
| const { | |||
| action, | |||
| avatar, | |||
| className, | |||
There was a problem hiding this comment.
useSlot already handle the className for root slot.
Confirmed by testClassName in describeConformance() suite.
Thanks for pointing out, added to the migration guide. |
DiegoAndai
approved these changes
Jan 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #41281
close #37585