[core][utils] Fix useTimeout clear lifecycle #44897
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oliviertassinari
added
package: utils
Netlify deploy previewhttps://deploy-preview-44897--material-ui.netlify.app/ Bundle size reportDetails of bundle changes (Toolpad) |
romgrk
reviewed
Jan 3, 2025
Comment on lines
+38
to
+39
| // eslint-disable-next-line react-hooks/exhaustive-deps | ||
| useEnhancedEffect(timeout.disposeEffect, []); |
There was a problem hiding this comment.
I would use a stable deps like useOnMount does:
const EMPTY = [] as unknown[];
// ...
useEnhancedEffect(effect, EMPTY);
romgrk
reviewed
Jan 3, 2025
| import useLazyRef from '../useLazyRef/useLazyRef'; | ||
| import useOnMount from '../useOnMount/useOnMount'; | ||
| import useLazyRef from '../useLazyRef'; | ||
| import useEnhancedEffect from '../useEnhancedEffect'; |
There was a problem hiding this comment.
It's not the first time I see useEnhancedEffect cause such issue, the hook makes it less apparent that useLayoutEffect is used, and that it runs on a different cycle than useEffect.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As far as I know, using
useOnMount()is wrong in this context. We need to clear the timeout synchronously with the component unmounts.See facebook/react#19671, with https://codesandbox.io/p/sandbox/unruffled-banzai-7zzr6k?file=%2Fsrc%2FDemo.tsx that illustrates the difference in behavior:
It seems the root cause of why mui/mui-x#14987. This fix is upstream of: mui/mui-x#16031, but it might be best to first merge downstream, so we test it with a smaller userbase.