Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[material-ui][Alert] complete slots and slotProps #44971

Merged
merged 7 commits into from
Jan 10, 2025

Conversation

siriwatknp
Copy link
Member

@siriwatknp siriwatknp commented Jan 8, 2025

Added missing slots: root, icon, message and `action.


@siriwatknp siriwatknp added package: material-ui Specific to @mui/material component: alert This is the name of the generic UI component, not the React module! labels Jan 8, 2025
@mui-bot
Copy link

mui-bot commented Jan 8, 2025

Netlify deploy preview

https://deploy-preview-44971--material-ui.netlify.app/

@material-ui/lab: parsed: +0.12% , gzip: +0.13%
Alert: parsed: +0.36% , gzip: +0.30%
@material-ui/core: parsed: +0.07% , gzip: +0.06%

Bundle size report

Details of bundle changes (Toolpad)
Details of bundle changes

Generated by 🚫 dangerJS against 0e09474

Copy link
Contributor

@sai6855 sai6855 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just added 2 suggestions

packages/mui-material/src/Alert/Alert.d.ts Outdated Show resolved Hide resolved
packages/mui-material/src/Alert/Alert.d.ts Outdated Show resolved Hide resolved
packages/mui-material/src/Alert/Alert.js Outdated Show resolved Hide resolved
packages/mui-material/src/Alert/Alert.js Show resolved Hide resolved
packages/mui-material/src/Alert/Alert.js Outdated Show resolved Hide resolved
@@ -64,7 +64,7 @@ export interface ConformanceOptions {
testStateOverrides?: { prop?: string; value?: any; styleKey: string };
testCustomVariant?: boolean;
testVariantProps?: object;
testLegacyComponentsProp?: boolean;
testLegacyComponentsProp?: boolean | string[];
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to add this to be able to test specific slot of components.*

@siriwatknp siriwatknp merged commit 60106b3 into mui:master Jan 10, 2025
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: alert This is the name of the generic UI component, not the React module! package: material-ui Specific to @mui/material
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants