[material-ui][Snackbar] Add Slots and SlotProps #45103
Open
+512
−37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Netlify deploy previewhttps://deploy-preview-45103--material-ui.netlify.app/ @material-ui/core: parsed: +0.08% , gzip: +0.06% Bundle size reportDetails of bundle changes (Toolpad) |
Signed-off-by: Harry Whorlow <[email protected]>
|
@DiegoAndai @siriwatknp ready for review! |
harry-whorlow
commented
Jan 24, 2025
| /> |
There was a problem hiding this comment.
One small point
This is why the docs:typescript:formatted is failing, but I'm confused as to why... As every other example of ---.tsx.preview dose not include a break line, but for some reason docs:typescript:formatted throws an error here, I'll run the command locally and it passes fine 🙃
aarongarciah
added
component: snackbar
aarongarciah
changed the title
github-actions
bot
added
the
PR: out-of-date
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
part of #41281
This PR adds slot and slotProps, whilst deprecating components.
Slot:
SlotProps: