Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update SwipeableDrawer docs #45126

Open
wants to merge 1 commit into
base: v4.x
Choose a base branch
from
Open

Update SwipeableDrawer docs #45126

wants to merge 1 commit into from

Conversation

MFatihY
Copy link

@MFatihY MFatihY commented Jan 26, 2025

Correct possessive pronoun

Correct possessive pronoun

Signed-off-by: Mehmet Fatih Yıldırım <[email protected]>
@ZeeshanTamboli ZeeshanTamboli changed the base branch from v4.x to master January 27, 2025 06:08
@ZeeshanTamboli ZeeshanTamboli changed the base branch from master to v4.x January 27, 2025 06:09
Copy link
Member

@ZeeshanTamboli ZeeshanTamboli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aarongarciah @DiegoAndai Should we accept v4 contributions? Do we deploy its docs? Viewing v4 docs is still supported, and the typo is already fixed in v5 and v6.

@aarongarciah
Copy link
Member

aarongarciah commented Jan 27, 2025

@ZeeshanTamboli v4 still has lots of users so I think it's a good idea to accept these contributions.

@aarongarciah
Copy link
Member

aarongarciah commented Jan 27, 2025

(closed by mistake 😅)

@ZeeshanTamboli
Copy link
Member

@ZeeshanTamboli v4 still has lots of users so I think it's a good idea to accept these contributions.

@aarongarciah Agree. I'll let you handle this PR.

@zannager zannager added the component: drawer This is the name of the generic UI component, not the React module! label Jan 27, 2025
@DiegoAndai DiegoAndai self-requested a review January 28, 2025 19:58
@DiegoAndai DiegoAndai self-requested a review January 29, 2025 20:37
Copy link
Member

@DiegoAndai DiegoAndai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MFatihY may I ask you to review the failing CI checks? You can find some guidance in: https://github.com/mui/material-ui/blob/v4.x/CONTRIBUTING.md

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: drawer This is the name of the generic UI component, not the React module!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants