-
-
Notifications
You must be signed in to change notification settings - Fork 32.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update SwipeableDrawer docs #45126
base: v4.x
Are you sure you want to change the base?
Update SwipeableDrawer docs #45126
Conversation
Correct possessive pronoun Signed-off-by: Mehmet Fatih Yıldırım <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@aarongarciah @DiegoAndai Should we accept v4 contributions? Do we deploy its docs? Viewing v4 docs is still supported, and the typo is already fixed in v5 and v6.
@ZeeshanTamboli v4 still has lots of users so I think it's a good idea to accept these contributions. |
(closed by mistake 😅) |
@aarongarciah Agree. I'll let you handle this PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@MFatihY may I ask you to review the failing CI checks? You can find some guidance in: https://github.com/mui/material-ui/blob/v4.x/CONTRIBUTING.md
Correct possessive pronoun