-
-
Notifications
You must be signed in to change notification settings - Fork 32.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Popover] Fix bad positioning on IOS devices #4638
Merged
Merged
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
db6583b
Fix popover positioning on IOS
w01fgang 13a9ce5
Merge remote-tracking branch 'callemall/master' into fixPopoverIOS
w01fgang bb81075
move getOffsetTop to ios helper
w01fgang 9ad0c51
move getOffsetTop(el) inside if isIOS block
w01fgang 9002ef7
fix: test for isIOS helper
w01fgang 7b3b6ad
use fix only in input field is focused
w01fgang 82e9455
make test pass
w01fgang File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,20 @@ | ||
/** | ||
* Returns a number of pixels from the top of the screen for given dom element. | ||
* | ||
* @param {object} dom element | ||
* @returns {number} A position from the top of the screen in pixels | ||
*/ | ||
export const getOffsetTop = (elem) => { | ||
let yPos = elem.offsetTop; | ||
let tempEl = elem.offsetParent; | ||
|
||
while (tempEl != null) { | ||
yPos += tempEl.offsetTop; | ||
tempEl = tempEl.offsetParent; | ||
} | ||
|
||
return yPos; | ||
}; | ||
|
||
|
||
export const isIOS = () => /iPad|iPhone|iPod/.test(window.navigator.userAgent) && !window.MSStream; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,44 @@ | ||
/* eslint-env mocha */ | ||
import {isIOS} from './isIOS'; | ||
import {assert} from 'chai'; | ||
|
||
describe('IOS detection helper', () => { | ||
// skip tests on PhantomJS because __defineGetter__ method doesn't work | ||
if (/PhantomJS/.test(window.navigator.userAgent)) return; | ||
|
||
/* eslint-disable max-len */ | ||
const userAgentsWithIOS = [ | ||
'Mozilla/5.0 (iPhone; CPU iPhone OS 7_0 like Mac OS X) AppleWebKit/537.51.1 (KHTML, like Gecko) Version/7.0 Mobile/11A465 Safari/9537.53', | ||
'Mozilla/5.0 (iPad; CPU OS 7_0 like Mac OS X) AppleWebKit/537.51.1 (KHTML, like Gecko) Version/7.0 Mobile/11A465 Safari/9537.53', | ||
'Mozilla/5.0 (iPod; U; CPU like Mac OS X; en) AppleWebKit/420.1 (KHTML, like Gecko) Version/3.0 Mobile/3A101a Safari/419.3', | ||
]; | ||
const nonIOSuserAgents = [ | ||
'Mozilla/5.0 (compatible; MSIE 9.0; Windows Phone OS 7.5; Trident/5.0; IEMobile/9.0)', | ||
'Mozilla/5.0 (Linux; Android 4.4.4; Nexus 7 Build/KTU84Q) AppleWebKit/537.36 (KHTML, like Gecko) Version/4.0 Chrome/33.0.0.0 Safari/537.36', | ||
'Mozilla/5.0 (BlackBerry; U; BlackBerry 9900; en) AppleWebKit/534.11+ (KHTML, like Gecko) Version/7.1.0.346 Mobile Safari/534.11+', | ||
]; | ||
/* eslint-enable max-len */ | ||
|
||
userAgentsWithIOS.forEach((agent) => { | ||
const input = document.createElement('INPUT'); | ||
document.body.appendChild(input); | ||
input.focus(); | ||
it('should decect IOS', () => { | ||
window.navigator.__defineGetter__('userAgent', () => agent); // eslint-disable-line no-underscore-dangle,max-len | ||
assert.strictEqual(isIOS(), true); | ||
}); | ||
}); | ||
|
||
nonIOSuserAgents.forEach((agent) => { | ||
it('should NOT decect IOS', () => { | ||
window.navigator.__defineGetter__('userAgent', () => agent); // eslint-disable-line no-underscore-dangle,max-len | ||
assert.strictEqual(isIOS(), false); | ||
}); | ||
}); | ||
|
||
after(() => { | ||
window.navigator.__defineGetter__('userAgent', function getUserAgent() { // eslint-disable-line no-underscore-dangle,max-len | ||
return `${this.appCodeName}/${this.appVersion}`; | ||
}); | ||
}); | ||
}); |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Side node, with the
next
branch we would be using activeElement