[DatePicker] Add keyboard support to inline mode #4945
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[docs] Add v0.15.3 to the versions.json
muibot
added
PR: Needs Review
PR: needs revision
|
@caesay Nice PR! I just had one issue. When we change the date through keyboard and hit |
|
@aahan96 I've added a commit which handles the enter key. |
| hintText="Keyboard Enabled Dialog" | ||
| container="inline" | ||
| mode="landscape" | ||
| keyboardEnabled={true} |
There was a problem hiding this comment.
I have seen other places in the code where props like these are alphabetically sorted. Is that a convention? Should it be done here?
There was a problem hiding this comment.
@nicolaiskogheim propType declarations are definitely alphabetical. I don't know about prop assignments, but either way this is just the docs file and the previous examples don't follow this rule either.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When
container=inlineandkeyboardEnabled=trueon a datepicker component, this enables keyboard support. You can tab in, type a date, tab out. Also, clicking directly on the control also focuses the textbox.I'm re-using the date state variable for the current textbox value as well as the stored date object, if this needs to be changed let me know how you would like it to be implemented instead.
Issue #4219 should likely also be looked at in this pull request to ensure that the popup calendar doesn't hide the textbox while it has focus.(fixed with b3ed601)Closes mui/mui-x#6232