Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Improvement] DatePicker properties autoOk, minDate e maxDate #538

Merged
merged 5 commits into from
Apr 17, 2015
Merged

[Improvement] DatePicker properties autoOk, minDate e maxDate #538

merged 5 commits into from
Apr 17, 2015

Conversation

castrolol
Copy link
Contributor

Improvement in DatePicker

  • autoOk - true for automatically Accepting if click on a date directly;
  • minDate - minimiun selectable date;
  • maxDate - maximum selectable date.

references the issue mui/mui-x#7540

Improvement in DatePicker:

autoOk - true for automatically Accepting if click on a date directly;
minDate - minimiun selectable date;
maxDate - maximum selectable date.

issue #427
Added autoOk in docs
@hai-cea
Copy link
Member

hai-cea commented Apr 15, 2015

@castrolol Thanks for PR! It looks great - I just have a couple suggestions.

  1. If autoOk is set, I think we should remove the OK and Cancel buttons.
  2. Also, what do you think about disabling the previous month button once we go past the minimum date and disable the next month button once we go past the max date?

Hai

Adds disable month buttons with max and min date, hide the ok button
when autoOk is true
@castrolol
Copy link
Contributor Author

@hai-cea the suggestions are done :D
I believe that the cancel button should stay

@jkruder
Copy link
Contributor

jkruder commented Apr 15, 2015

See PR #511. The min/max date has been implemented (along with adding year selection). The only aspect of this request that does not exist is the autoOk prop.

@mmrtnz mmrtnz mentioned this pull request Apr 17, 2015
mmrtnz added a commit that referenced this pull request Apr 17, 2015
[Improvement] DatePicker properties autoOk, minDate e maxDate
@mmrtnz mmrtnz merged commit c6967d1 into mui:master Apr 17, 2015
@mmrtnz
Copy link
Contributor

mmrtnz commented Apr 17, 2015

Thanks for making the corrections @castrolol! Fixes mui/mui-x#7543 and mui/mui-x#7540

@mofas
Copy link

mofas commented Apr 20, 2015

awesome work~~!

@jhubert
Copy link

jhubert commented Jun 8, 2015

@castrolol It seems the autoOk has an issue. If I have auto-accept on and click next or previous month, the date gets auto-accepted. http://material-ui.com/#/components/date-picker

@castrolol
Copy link
Contributor Author

@jhubert in the docs not working the auto accept, in home I 'll test ;D

@zannager zannager added component: date picker This is the name of the generic UI component, not the React module! component: pickers This is the name of the generic UI component, not the React module! labels Mar 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: date picker This is the name of the generic UI component, not the React module! component: pickers This is the name of the generic UI component, not the React module!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants