Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Layout] Flex grow/shrink/basis/order props added. #8263

Closed
wants to merge 1 commit into from
Closed

[Layout] Flex grow/shrink/basis/order props added. #8263

wants to merge 1 commit into from

Conversation

AndriusBil
Copy link
Contributor

#6140

Grow prop added.
Shrink prop added.
Basis prop added.
Order prop added.

@oliviertassinari
Copy link
Member

oliviertassinari commented Sep 18, 2017 •
edited
Loading

@AndriusBil Thanks for the PR, the effort is appreciated! :)
However, I think that the PR is going to introduce too much CSS in the page (4 * 12 + 7 = 55). The component already inject 87 selectors. This is a ~60% increase.
We are going to need #7633 to more forward here.

@oliviertassinari oliviertassinari added on hold There is a blocker, we need to wait v1 labels Sep 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
on hold There is a blocker, we need to wait
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AndriusBil @oliviertassinari