[DataGrid] Remove legacy editing API event: rowEditCommit (#12087)

mui · Apr 4, 2024 · e54ca31 · e54ca31
1 parent acf7833
commit e54ca31
Show file tree

Hide file tree

Showing 13 changed files with 2 additions and 80 deletions.
diff --git a/docs/data/data-grid/events/events.json b/docs/data/data-grid/events/events.json
@@ -300,14 +300,6 @@
     "event": "MuiEvent<React.MouseEvent<HTMLElement>>",
     "componentProp": "onRowDoubleClick"
   },
-  {
-    "projects": ["x-data-grid", "x-data-grid-pro", "x-data-grid-premium"],
-    "name": "rowEditCommit",
-    "description": "Fired when the props of the edit input are committed.",
-    "params": "GridRowId",
-    "event": "MuiEvent<MuiBaseEvent>",
-    "componentProp": "onRowEditCommit"
-  },
   {
     "projects": ["x-data-grid", "x-data-grid-pro", "x-data-grid-premium"],
     "name": "rowEditStart",

diff --git a/docs/data/migration/migration-data-grid-v5/migration-data-grid-v5.md b/docs/data/migration/migration-data-grid-v5/migration-data-grid-v5.md
@@ -423,7 +423,7 @@ Most of this breaking change is handled by `preset-safe` codemod but some furthe
    />
   ```
 - The `editCellPropsChange` event was removed. If you still need it please file a new issue so we can propose an alternative.
-- The `cellEditCommit` event was removed and the `processRowUpdate` prop can be used in place. More information, check the [docs](https://mui.com/x/react-data-grid/editing/#server-side-persistence) section about the topic.
+- The events `cellEditCommit` and `rowEditCommit` and related props were removed. The `processRowUpdate` prop can be used in place. More information, check the [docs](https://mui.com/x/react-data-grid/editing/#server-side-persistence) section about the topic.
 - The `editRowsModel` and `onEditRowsModelChange` props were removed. The [`cellModesModel`](https://mui.com/x/react-data-grid/editing/#controlled-mode) or [`rowModesModel`](https://mui.com/x/react-data-grid/editing/#controlled-mode) props can be used to achieve the same goal.
 - The `GridEditRowsModel` type was removed.
 - The following API methods were removed:

diff --git a/docs/pages/x/api/data-grid/data-grid-premium.json b/docs/pages/x/api/data-grid/data-grid-premium.json
@@ -448,13 +448,6 @@
         "describedArgs": ["params", "event", "details"]
       }
     },
-    "onRowEditCommit": {
-      "type": { "name": "func" },
-      "signature": {
-        "type": "function(id: GridRowId, event: MuiEvent<MuiBaseEvent>) => void",
-        "describedArgs": ["id", "event"]
-      }
-    },
     "onRowEditStart": {
       "type": { "name": "func" },
       "signature": {

diff --git a/docs/pages/x/api/data-grid/data-grid-pro.json b/docs/pages/x/api/data-grid/data-grid-pro.json
@@ -407,13 +407,6 @@
         "describedArgs": ["params", "event", "details"]
       }
     },
-    "onRowEditCommit": {
-      "type": { "name": "func" },
-      "signature": {
-        "type": "function(id: GridRowId, event: MuiEvent<MuiBaseEvent>) => void",
-        "describedArgs": ["id", "event"]
-      }
-    },
     "onRowEditStart": {
       "type": { "name": "func" },
       "signature": {

diff --git a/docs/pages/x/api/data-grid/data-grid.json b/docs/pages/x/api/data-grid/data-grid.json
@@ -320,13 +320,6 @@
         "describedArgs": ["params", "event", "details"]
       }
     },
-    "onRowEditCommit": {
-      "type": { "name": "func" },
-      "signature": {
-        "type": "function(id: GridRowId, event: MuiEvent<MuiBaseEvent>) => void",
-        "describedArgs": ["id", "event"]
-      }
-    },
     "onRowEditStart": {
       "type": { "name": "func" },
       "signature": {

diff --git a/docs/translations/api-docs/data-grid/data-grid-premium/data-grid-premium.json b/docs/translations/api-docs/data-grid/data-grid-premium/data-grid-premium.json
@@ -478,13 +478,6 @@
         "details": "Additional details for this callback."
       }
     },
-    "onRowEditCommit": {
-      "description": "Callback fired when the row changes are committed.",
-      "typeDescriptions": {
-        "id": "The row id.",
-        "event": "The event that caused this prop to be called."
-      }
-    },
     "onRowEditStart": {
       "description": "Callback fired when the row turns to edit mode.",
       "typeDescriptions": {

diff --git a/docs/translations/api-docs/data-grid/data-grid-pro/data-grid-pro.json b/docs/translations/api-docs/data-grid/data-grid-pro/data-grid-pro.json
@@ -440,13 +440,6 @@
         "details": "Additional details for this callback."
       }
     },
-    "onRowEditCommit": {
-      "description": "Callback fired when the row changes are committed.",
-      "typeDescriptions": {
-        "id": "The row id.",
-        "event": "The event that caused this prop to be called."
-      }
-    },
     "onRowEditStart": {
       "description": "Callback fired when the row turns to edit mode.",
       "typeDescriptions": {

diff --git a/docs/translations/api-docs/data-grid/data-grid/data-grid.json b/docs/translations/api-docs/data-grid/data-grid/data-grid.json
@@ -338,13 +338,6 @@
         "details": "Additional details for this callback."
       }
     },
-    "onRowEditCommit": {
-      "description": "Callback fired when the row changes are committed.",
-      "typeDescriptions": {
-        "id": "The row id.",
-        "event": "The event that caused this prop to be called."
-      }
-    },
     "onRowEditStart": {
       "description": "Callback fired when the row turns to edit mode.",
       "typeDescriptions": {

diff --git a/packages/grid/x-data-grid-premium/src/DataGridPremium/DataGridPremium.tsx b/packages/grid/x-data-grid-premium/src/DataGridPremium/DataGridPremium.tsx
@@ -736,12 +736,6 @@ DataGridPremiumRaw.propTypes = {
    * @param {GridCallbackDetails} details Additional details for this callback.
    */
   onRowDoubleClick: PropTypes.func,
-  /**
-   * Callback fired when the row changes are committed.
-   * @param {GridRowId} id The row id.
-   * @param {MuiEvent<MuiBaseEvent>} event The event that caused this prop to be called.
-   */
-  onRowEditCommit: PropTypes.func,
   /**
    * Callback fired when the row turns to edit mode.
    * @param {GridRowParams} params With all properties from [[GridRowParams]].

diff --git a/packages/grid/x-data-grid-pro/src/DataGridPro/DataGridPro.tsx b/packages/grid/x-data-grid-pro/src/DataGridPro/DataGridPro.tsx
@@ -669,12 +669,6 @@ DataGridProRaw.propTypes = {
    * @param {GridCallbackDetails} details Additional details for this callback.
    */
   onRowDoubleClick: PropTypes.func,
-  /**
-   * Callback fired when the row changes are committed.
-   * @param {GridRowId} id The row id.
-   * @param {MuiEvent<MuiBaseEvent>} event The event that caused this prop to be called.
-   */
-  onRowEditCommit: PropTypes.func,
   /**
    * Callback fired when the row turns to edit mode.
    * @param {GridRowParams} params With all properties from [[GridRowParams]].

diff --git a/packages/grid/x-data-grid/src/DataGrid/DataGrid.tsx b/packages/grid/x-data-grid/src/DataGrid/DataGrid.tsx
@@ -525,12 +525,6 @@ DataGridRaw.propTypes = {
    * @param {GridCallbackDetails} details Additional details for this callback.
    */
   onRowDoubleClick: PropTypes.func,
-  /**
-   * Callback fired when the row changes are committed.
-   * @param {GridRowId} id The row id.
-   * @param {MuiEvent<MuiBaseEvent>} event The event that caused this prop to be called.
-   */
-  onRowEditCommit: PropTypes.func,
   /**
    * Callback fired when the row turns to edit mode.
    * @param {GridRowParams} params With all properties from [[GridRowParams]].

diff --git a/packages/grid/x-data-grid/src/models/events/gridEventLookup.ts b/packages/grid/x-data-grid/src/models/events/gridEventLookup.ts
@@ -19,7 +19,7 @@ import type { GridSortModel } from '../gridSortModel';
 import type { GridRowSelectionModel } from '../gridRowSelectionModel';
 import type { ElementSize } from '../elementSize';
 import type { MuiBaseEvent } from '../muiEvent';
-import type { GridGroupNode, GridRowId } from '../gridRows';
+import type { GridGroupNode } from '../gridRows';
 import type { GridColumnVisibilityModel } from '../../hooks/features/columns';
 import type { GridStrategyProcessorName } from '../../hooks/core/strategyProcessing';
 import { GridRowEditStartParams, GridRowEditStopParams } from '../params/gridRowParams';
@@ -506,10 +506,6 @@ export interface GridEventLookup
     params: GridRowEditStopParams;
     event: MuiBaseEvent;
   };
-  /**
-   * Fired when the props of the edit input are committed.
-   */
-  rowEditCommit: { params: GridRowId; event: MuiBaseEvent };
 
   // Focus
   /**

diff --git a/packages/grid/x-data-grid/src/models/props/DataGridProps.ts b/packages/grid/x-data-grid/src/models/props/DataGridProps.ts
@@ -480,12 +480,6 @@ export interface DataGridPropsWithoutDefaultValue<R extends GridValidRowModel =
    * @param {MuiEvent<MuiBaseEvent>} event The event that caused this prop to be called.
    */
   onCellEditStop?: GridEventListener<'cellEditStop'>;
-  /**
-   * Callback fired when the row changes are committed.
-   * @param {GridRowId} id The row id.
-   * @param {MuiEvent<MuiBaseEvent>} event The event that caused this prop to be called.
-   */
-  onRowEditCommit?: GridEventListener<'rowEditCommit'>;
   /**
    * Callback fired when the row turns to edit mode.
    * @param {GridRowParams} params With all properties from [[GridRowParams]].