Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DataGrid] Example not working in /tables #2039

Closed
dmi4uv opened this issue Jul 5, 2021 · 7 comments · Fixed by #2117
Closed

[DataGrid] Example not working in /tables #2039

dmi4uv opened this issue Jul 5, 2021 · 7 comments · Fixed by #2117
Labels
bug 🐛 Something doesn't work component: data grid This is the name of the generic UI component, not the React module! docs Improvements or additions to the documentation priority: important This change can make a difference

Comments

@dmi4uv
Copy link

dmi4uv commented Jul 5, 2021

Hi!
Data Table exampe not working in CodeSandbox
bug
@eps1lon eps1lon transferred this issue from mui/material-ui Jul 5, 2021
@dtassone dtassone added the status: waiting for author Issue with insufficient information label Jul 5, 2021
@oliviertassinari oliviertassinari added bug 🐛 Something doesn't work priority: important This change can make a difference component: data grid This is the name of the generic UI component, not the React module! docs Improvements or additions to the documentation and removed status: waiting for author Issue with insufficient information labels Jul 5, 2021
@oliviertassinari
Copy link
Member

oliviertassinari commented Jul 5, 2021 •
edited
Loading

A regression from: #1513

@eps1lon this case is interesting, the fix is to be done on the core side, but the ownership is on the x side.

@oliviertassinari oliviertassinari changed the title Data table example not working [DataGrid] Example not working in /tables Jul 5, 2021
@oliviertassinari
Copy link
Member

oliviertassinari commented Jul 8, 2021 •
edited
Loading

@mui-org/x Who wants to fix it? We need a fix on master. It's a good reminder that breaking changes have a cost.

@dtassone
Copy link
Member

dtassone commented Jul 9, 2021

getValue was refactored for perf reason. You now need to pass the row id and the column field as arguments.
More about this change on https://github.com/mui-org/material-ui-x/releases/tag/v4.0.0-alpha.29

fix sandbox https://codesandbox.io/s/sweet-greider-jmudl

@dtassone dtassone closed this as completed Jul 9, 2021
@dtassone dtassone reopened this Jul 9, 2021
@dtassone
Copy link
Member

dtassone commented Jul 9, 2021

@oliviertassinari what issue on core are you referring to?

@oliviertassinari
Copy link
Member

oliviertassinari commented Jul 9, 2021 •
edited
Loading

what issue on core are you referring to?

I'm referring to #2039 (comment)

@dtassone
Copy link
Member

dtassone commented Jul 9, 2021

ok closing as explained #2039 (comment)

@dtassone dtassone closed this as completed Jul 9, 2021
@oliviertassinari
Copy link
Member

It's about fixing the demo.

This was referenced Jul 10, 2021
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug 🐛 Something doesn't work component: data grid This is the name of the generic UI component, not the React module! docs Improvements or additions to the documentation priority: important This change can make a difference
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[DataGrid] Fix localeText type oliviertassinari/mui-x
3 participants
@dtassone @oliviertassinari @dmi4uv